From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Fri, 12 Oct 2012 10:08:32 -0400 Subject: [PATCH 1/2] ARM: config: sort select statements alphanumerically In-Reply-To: References: <20121012132553.GK28061@n2100.arm.linux.org.uk> Message-ID: <20121012140832.GO12330@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 12, 2012 at 02:26:19PM +0100, Russell King wrote: > As suggested by Andrew Morton: > > This is a pet peeve of mine. Any time there's a long list of items > (header file inclusions, kconfig entries, array initalisers, etc) and > someone wants to add a new item, they *always* go and stick it at the > end of the list. > > Guys, don't do this. Either put the new item into a randomly-chosen > position or, probably better, alphanumerically sort the list. > > lets sort all our select statements alphanumerically. This commit was > created by the following perl: > > while (<>) { > while (/\\\s*$/) { > $_ .= <>; > } > undef %selects if /^\s*config\s+/; > if (/^\s+select\s+(\w+).*/) { > if (defined($selects{$1})) { > if ($selects{$1} eq $_) { > print STDERR "Warning: removing duplicated $1 entry\n"; > } else { > print STDERR "Error: $1 differently selected\n". > "\tOld: $selects{$1}\n". > "\tNew: $_\n"; > exit 1; > } > } > $selects{$1} = $_; > next; > } > if (%selects and (/^\s*$/ or /^\s+help/)) { > foreach $k (sort (keys %selects)) { > print "$selects{$k}"; > } > undef %selects; > } > print; > } > if (%selects) { > foreach $k (sort (keys %selects)) { > print "$selects{$k}"; > } > } > > It found two duplicates: > > Warning: removing duplicated S5P_SETUP_MIPIPHY entry > Warning: removing duplicated HARDIRQS_SW_RESEND entry > > and they are identical duplicates, hence the shrinkage in the diffstat > of two lines. > > Signed-off-by: Russell King For ARCH_DOVE, ARCH_KIRKWOOD, ARCH_MV78XX0, ARCH_ORION5X, PLAT_ORION, and PLAT_ORION_LEGACY: Acked-by: Jason Cooper thx, Jason.