linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: SPEAr: Vco-pll: Fix compilation warning
Date: Fri, 12 Oct 2012 08:05:06 -0700	[thread overview]
Message-ID: <20121012150506.2941.11751@nucleus> (raw)
In-Reply-To: <CAOh2x=npo5A0gvk75Cc5MMzp_qfA4GUeETdCwN-wvA4LCsSVYw@mail.gmail.com>

Quoting viresh kumar (2012-10-11 22:51:05)
> Hi Mike,
> 
> Because you are back now, can you please push this patch?
> 

Done.

Regards,
Mike

> On Thu, Oct 4, 2012 at 3:19 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > Currently we are getting following warning for SPEAr clk-vco-pll.
> >
> > "warning: i is used uninitialized in this function."
> >
> > This is because we are getting value of i by passing its pointer to another
> > routine.
> >
> > The variables here are really not used uninitialized.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> >
> > Andrew,
> >
> > I know this must have gone through Mike Turquette. But he is not around for a
> > week. As, this is a pretty small change, can you take it upstream?
> >
> > drivers/clk/spear/clk-vco-pll.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/spear/clk-vco-pll.c b/drivers/clk/spear/clk-vco-pll.c
> > index 5f1b6ba..1b9b65b 100644
> > --- a/drivers/clk/spear/clk-vco-pll.c
> > +++ b/drivers/clk/spear/clk-vco-pll.c
> > @@ -147,7 +147,7 @@ static int clk_pll_set_rate(struct clk_hw *hw, unsigned long drate,
> >         struct clk_pll *pll = to_clk_pll(hw);
> >         struct pll_rate_tbl *rtbl = pll->vco->rtbl;
> >         unsigned long flags = 0, val;
> > -       int i;
> > +       int uninitialized_var(i);
> >
> >         clk_pll_round_rate_index(hw, drate, NULL, &i);
> >
> > --
> > 1.7.12.rc2.18.g61b472e
> >
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2012-10-12 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04  9:49 [PATCH] clk: SPEAr: Vco-pll: Fix compilation warning Viresh Kumar
2012-10-12  5:51 ` viresh kumar
2012-10-12 15:05   ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121012150506.2941.11751@nucleus \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).