* [PATCH] clk: SPEAr: Vco-pll: Fix compilation warning
@ 2012-10-04 9:49 Viresh Kumar
2012-10-12 5:51 ` viresh kumar
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2012-10-04 9:49 UTC (permalink / raw)
To: linux-arm-kernel
Currently we are getting following warning for SPEAr clk-vco-pll.
"warning: i is used uninitialized in this function."
This is because we are getting value of i by passing its pointer to another
routine.
The variables here are really not used uninitialized.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Andrew,
I know this must have gone through Mike Turquette. But he is not around for a
week. As, this is a pretty small change, can you take it upstream?
drivers/clk/spear/clk-vco-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/spear/clk-vco-pll.c b/drivers/clk/spear/clk-vco-pll.c
index 5f1b6ba..1b9b65b 100644
--- a/drivers/clk/spear/clk-vco-pll.c
+++ b/drivers/clk/spear/clk-vco-pll.c
@@ -147,7 +147,7 @@ static int clk_pll_set_rate(struct clk_hw *hw, unsigned long drate,
struct clk_pll *pll = to_clk_pll(hw);
struct pll_rate_tbl *rtbl = pll->vco->rtbl;
unsigned long flags = 0, val;
- int i;
+ int uninitialized_var(i);
clk_pll_round_rate_index(hw, drate, NULL, &i);
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] clk: SPEAr: Vco-pll: Fix compilation warning
2012-10-04 9:49 [PATCH] clk: SPEAr: Vco-pll: Fix compilation warning Viresh Kumar
@ 2012-10-12 5:51 ` viresh kumar
2012-10-12 15:05 ` Mike Turquette
0 siblings, 1 reply; 3+ messages in thread
From: viresh kumar @ 2012-10-12 5:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mike,
Because you are back now, can you please push this patch?
On Thu, Oct 4, 2012 at 3:19 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Currently we are getting following warning for SPEAr clk-vco-pll.
>
> "warning: i is used uninitialized in this function."
>
> This is because we are getting value of i by passing its pointer to another
> routine.
>
> The variables here are really not used uninitialized.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>
> Andrew,
>
> I know this must have gone through Mike Turquette. But he is not around for a
> week. As, this is a pretty small change, can you take it upstream?
>
> drivers/clk/spear/clk-vco-pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spear/clk-vco-pll.c b/drivers/clk/spear/clk-vco-pll.c
> index 5f1b6ba..1b9b65b 100644
> --- a/drivers/clk/spear/clk-vco-pll.c
> +++ b/drivers/clk/spear/clk-vco-pll.c
> @@ -147,7 +147,7 @@ static int clk_pll_set_rate(struct clk_hw *hw, unsigned long drate,
> struct clk_pll *pll = to_clk_pll(hw);
> struct pll_rate_tbl *rtbl = pll->vco->rtbl;
> unsigned long flags = 0, val;
> - int i;
> + int uninitialized_var(i);
>
> clk_pll_round_rate_index(hw, drate, NULL, &i);
>
> --
> 1.7.12.rc2.18.g61b472e
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] clk: SPEAr: Vco-pll: Fix compilation warning
2012-10-12 5:51 ` viresh kumar
@ 2012-10-12 15:05 ` Mike Turquette
0 siblings, 0 replies; 3+ messages in thread
From: Mike Turquette @ 2012-10-12 15:05 UTC (permalink / raw)
To: linux-arm-kernel
Quoting viresh kumar (2012-10-11 22:51:05)
> Hi Mike,
>
> Because you are back now, can you please push this patch?
>
Done.
Regards,
Mike
> On Thu, Oct 4, 2012 at 3:19 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > Currently we are getting following warning for SPEAr clk-vco-pll.
> >
> > "warning: i is used uninitialized in this function."
> >
> > This is because we are getting value of i by passing its pointer to another
> > routine.
> >
> > The variables here are really not used uninitialized.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> >
> > Andrew,
> >
> > I know this must have gone through Mike Turquette. But he is not around for a
> > week. As, this is a pretty small change, can you take it upstream?
> >
> > drivers/clk/spear/clk-vco-pll.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/spear/clk-vco-pll.c b/drivers/clk/spear/clk-vco-pll.c
> > index 5f1b6ba..1b9b65b 100644
> > --- a/drivers/clk/spear/clk-vco-pll.c
> > +++ b/drivers/clk/spear/clk-vco-pll.c
> > @@ -147,7 +147,7 @@ static int clk_pll_set_rate(struct clk_hw *hw, unsigned long drate,
> > struct clk_pll *pll = to_clk_pll(hw);
> > struct pll_rate_tbl *rtbl = pll->vco->rtbl;
> > unsigned long flags = 0, val;
> > - int i;
> > + int uninitialized_var(i);
> >
> > clk_pll_round_rate_index(hw, drate, NULL, &i);
> >
> > --
> > 1.7.12.rc2.18.g61b472e
> >
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-12 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 9:49 [PATCH] clk: SPEAr: Vco-pll: Fix compilation warning Viresh Kumar
2012-10-12 5:51 ` viresh kumar
2012-10-12 15:05 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).