From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: vfp: fix save and restore when running on pre-VFPv3 and CONFIG_VFPv3 set
Date: Sat, 13 Oct 2012 10:02:55 +0100 [thread overview]
Message-ID: <20121013090255.GT28061@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1210130441300.5736@utopia.booyaka.com>
On Sat, Oct 13, 2012 at 04:46:18AM +0000, Paul Walmsley wrote:
>
> After commit 846a136881b8f73c1f74250bf6acfaa309cab1f2 ("ARM: vfp: fix
> saving d16-d31 vfp registers on v6+ kernels"), the OMAP 2430SDP board
> started crashing during boot with omap2plus_defconfig:
>
> [ 3.875122] mmcblk0: mmc0:e624 SD04G 3.69 GiB
> [ 3.915954] mmcblk0: p1
> [ 4.086639] Internal error: Oops - undefined instruction: 0 [#1] SMP ARM
> [ 4.093719] Modules linked in:
> [ 4.096954] CPU: 0 Not tainted (3.6.0-02232-g759e00b #570)
> [ 4.103149] PC is at vfp_reload_hw+0x1c/0x44
> [ 4.107666] LR is at __und_usr_fault_32+0x0/0x8
>
> It turns out that the context save/restore fix unmasked a latent bug in
> commit 5aaf254409f8d58229107b59507a8235b715a960 ("ARM: 6203/1: Make VFPv3
> usable on ARMv6"). When CONFIG_VFPv3 is set, but the kernel is booted on
> a pre-VFPv3 core, the code attempts to save and restore the d16-d31 VFP
> registers. These are only present on non-D16 VFPv3+, so the kernel dies
> with an undefined instruction exception. The kernel didn't crash before
> commit 846a136 because the save and restore code only touched d0-d15,
> present on all VFP.
>
> Fix to save and restore the d16-d31 registers only if they are
> present.
No. VFPv3D16 HWCAP means that the VFP supports just 16 double registers
- and it communicates this information to userspace. If this bit is clear,
and the VFP only has 16 double registers, then _that_ is a bug.
next prev parent reply other threads:[~2012-10-13 9:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 4:46 [PATCH] ARM: vfp: fix save and restore when running on pre-VFPv3 and CONFIG_VFPv3 set Paul Walmsley
2012-10-13 9:02 ` Russell King - ARM Linux [this message]
2012-10-13 10:50 ` Måns Rullgård
2012-10-13 13:36 ` Russell King - ARM Linux
2012-10-15 1:58 ` Paul Walmsley
2012-10-15 2:39 ` Mans Rullgard
2012-10-15 5:24 ` [PATCH v3] " Paul Walmsley
2012-10-15 17:53 ` Tony Lindgren
2012-10-16 17:13 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013090255.GT28061@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).