From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] Get early_printk() to work on socfpga board
Date: Mon, 15 Oct 2012 14:30:00 +0100 [thread overview]
Message-ID: <20121015133000.GA14915@page> (raw)
In-Reply-To: <20121015124852.GA26559@elf.ucw.cz>
Hi Pavel,
On Mon, Oct 15, 2012 at 02:48:52PM +0200, Pavel Machek wrote:
> Add ioremap, so that early_printk() works. Add common 8250.S so that
> code is not duplicated with picoxcell.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
>
> diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S
> new file mode 100644
> index 0000000..8db01ee
> --- /dev/null
> +++ b/arch/arm/include/debug/8250.S
> @@ -0,0 +1,27 @@
> +/*
> + * Copyright (c) 2011 Picochip Ltd., Jamie Iles
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * Derived from arch/arm/mach-davinci/include/mach/debug-macro.S to use 32-bit
> + * accesses to the 8250.
> + */
The APB on picoxcell only supports 32-bit accesses so we have to use
32-bit accesses for that platform, but others may need 8-bit accesses,
so naming this 8250_32.S may be more appropriate?
I did try making 8/32 bit accesses acompile-time configuration and
sharing with other platforms before but it looked a bit messy.
Otherwise:
Acked-by: Jamie Iles <jamie@jamieiles.com>
Jamie
prev parent reply other threads:[~2012-10-15 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 18:47 [RFC PATCHv4 0/1] arm: socfpga: Add initial support for Altera's SOCFPGA HW dinguyen at altera.com
2012-07-18 18:47 ` [RFC PATCHv4] ARM: socfpga: initial support for Altera's SOCFPGA platform dinguyen at altera.com
2012-07-18 19:29 ` Arnd Bergmann
2012-10-15 12:49 ` [RFC] Get early_printk() to work on socfpga board Pavel Machek
2012-10-15 13:30 ` Jamie Iles [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015133000.GA14915@page \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).