* [PATCH 1/1] pinctrl/at91: fix compatible order
@ 2012-10-12 9:23 Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 14:04 ` ludovic.desroches
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-12 9:23 UTC (permalink / raw)
To: linux-arm-kernel
the sam9x5 is new version of the rm9200 not the invert
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/pinctrl-at91.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 9c0fe11..bdb152b 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1331,8 +1331,8 @@ static void __devinit at91_gpio_probe_fixup(void)
}
static struct of_device_id at91_gpio_of_match[] __devinitdata = {
- { .compatible = "atmel,at91rm9200-gpio", .data = &at91rm9200_ops },
{ .compatible = "atmel,at91sam9x5-gpio", .data = &at91sam9x5_ops, },
+ { .compatible = "atmel,at91rm9200-gpio", .data = &at91rm9200_ops },
{ /* sentinel */ }
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 1/1] pinctrl/at91: fix compatible order
2012-10-12 9:23 [PATCH 1/1] pinctrl/at91: fix compatible order Jean-Christophe PLAGNIOL-VILLARD
@ 2012-10-12 14:04 ` ludovic.desroches
2012-10-15 12:33 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: ludovic.desroches @ 2012-10-12 14:04 UTC (permalink / raw)
To: linux-arm-kernel
Le 10/12/2012 11:23 AM, Jean-Christophe PLAGNIOL-VILLARD a ?crit :
> the sam9x5 is new version of the rm9200 not the invert
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/pinctrl/pinctrl-at91.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 9c0fe11..bdb152b 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -1331,8 +1331,8 @@ static void __devinit at91_gpio_probe_fixup(void)
> }
>
> static struct of_device_id at91_gpio_of_match[] __devinitdata = {
> - { .compatible = "atmel,at91rm9200-gpio", .data = &at91rm9200_ops },
> { .compatible = "atmel,at91sam9x5-gpio", .data = &at91sam9x5_ops, },
> + { .compatible = "atmel,at91rm9200-gpio", .data = &at91rm9200_ops },
> { /* sentinel */ }
> };
>
>
Do it also for at91_pinctrl_of_match[], there is the same issue.
Regards
Ludovic
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/1] pinctrl/at91: fix compatible order
2012-10-12 14:04 ` ludovic.desroches
@ 2012-10-15 12:33 ` Linus Walleij
2012-10-15 13:32 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2012-10-15 12:33 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 12, 2012 at 4:04 PM, ludovic.desroches
<ludovic.desroches@atmel.com> wrote:
> Le 10/12/2012 11:23 AM, Jean-Christophe PLAGNIOL-VILLARD a ?crit :
>
>> the sam9x5 is new version of the rm9200 not the invert
>>
>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> drivers/pinctrl/pinctrl-at91.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-at91.c
>> b/drivers/pinctrl/pinctrl-at91.c
>> index 9c0fe11..bdb152b 100644
>> --- a/drivers/pinctrl/pinctrl-at91.c
>> +++ b/drivers/pinctrl/pinctrl-at91.c
>> @@ -1331,8 +1331,8 @@ static void __devinit at91_gpio_probe_fixup(void)
>> }
>>
>> static struct of_device_id at91_gpio_of_match[] __devinitdata = {
>> - { .compatible = "atmel,at91rm9200-gpio", .data = &at91rm9200_ops
>> },
>> { .compatible = "atmel,at91sam9x5-gpio", .data = &at91sam9x5_ops,
>> },
>> + { .compatible = "atmel,at91rm9200-gpio", .data = &at91rm9200_ops
>> },
>> { /* sentinel */ }
>> };
>>
>
> Do it also for at91_pinctrl_of_match[], there is the same issue.
Shall I apply this patch to my at91 branch or will it be updated to
cover both cases?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/1] pinctrl/at91: fix compatible order
2012-10-15 12:33 ` Linus Walleij
@ 2012-10-15 13:32 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-15 13:32 UTC (permalink / raw)
To: linux-arm-kernel
On 14:33 Mon 15 Oct , Linus Walleij wrote:
> On Fri, Oct 12, 2012 at 4:04 PM, ludovic.desroches
> <ludovic.desroches@atmel.com> wrote:
> > Le 10/12/2012 11:23 AM, Jean-Christophe PLAGNIOL-VILLARD a ?crit :
> >
> >> the sam9x5 is new version of the rm9200 not the invert
> >>
> >> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >> Cc: Linus Walleij <linus.walleij@linaro.org>
> >> ---
> >> drivers/pinctrl/pinctrl-at91.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/pinctrl/pinctrl-at91.c
> >> b/drivers/pinctrl/pinctrl-at91.c
> >> index 9c0fe11..bdb152b 100644
> >> --- a/drivers/pinctrl/pinctrl-at91.c
> >> +++ b/drivers/pinctrl/pinctrl-at91.c
> >> @@ -1331,8 +1331,8 @@ static void __devinit at91_gpio_probe_fixup(void)
> >> }
> >>
> >> static struct of_device_id at91_gpio_of_match[] __devinitdata = {
> >> - { .compatible = "atmel,at91rm9200-gpio", .data = &at91rm9200_ops
> >> },
> >> { .compatible = "atmel,at91sam9x5-gpio", .data = &at91sam9x5_ops,
> >> },
> >> + { .compatible = "atmel,at91rm9200-gpio", .data = &at91rm9200_ops
> >> },
> >> { /* sentinel */ }
> >> };
> >>
> >
> > Do it also for at91_pinctrl_of_match[], there is the same issue.
>
> Shall I apply this patch to my at91 branch or will it be updated to
> cover both cases?
the one in your tree is ok
Best Regards,
J.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-15 13:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-12 9:23 [PATCH 1/1] pinctrl/at91: fix compatible order Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 14:04 ` ludovic.desroches
2012-10-15 12:33 ` Linus Walleij
2012-10-15 13:32 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).