From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/2] ARM: kexec: Check segment memory addresses
Date: Tue, 16 Oct 2012 18:16:01 +0100 [thread overview]
Message-ID: <20121016171601.GL23979@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20121016170900.GB1613@blackmetal.musicnaut.iki.fi>
On Tue, Oct 16, 2012 at 06:09:00PM +0100, Aaro Koskinen wrote:
> On Tue, Oct 16, 2012 at 05:32:26PM +0100, Will Deacon wrote:
> > Interesting, it sounds like kexec thinks that you don't have contiguous
> > memory from 0x80008000 to 0x803ad000. Can you provide some more information
> > about your physical memory map please?
>
> Well, I think it's because the patch is wrong. Shouldn't it be:
>
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index e29c333..a80192e 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -47,7 +47,7 @@ int machine_kexec_prepare(struct kimage *image)
>
> err = memblock_is_region_memory(current_segment->mem,
> current_segment->memsz);
> - if (err)
> + if (!err)
> return - EINVAL;
>
> err = get_user(header, (__be32*)current_segment->buf);
Oops, that's a howler! Thanks for spotting it. We should probably reflow the
code a bit because !err sounds like everything should be ok.
Fancy reworking the patch or do you want me to take care of this?
Cheers,
Will
prev parent reply other threads:[~2012-10-16 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 16:03 [RESEND PATCH 1/2] ARM: kexec: scan for dtb magic in segments Will Deacon
2012-09-20 16:03 ` [RESEND PATCH 2/2] ARM: kexec: Check segment memory addresses Will Deacon
2012-10-16 16:10 ` Aaro Koskinen
2012-10-16 16:32 ` Will Deacon
2012-10-16 17:09 ` Aaro Koskinen
2012-10-16 17:16 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016171601.GL23979@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).