From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 16 Oct 2012 10:43:19 -0700 Subject: [PATCH] ARM: OMAP2+: gpmc: Fix kernel BUG for DT boot mode In-Reply-To: <20121010143742.GE13724@beef> References: <1349773040-8204-1-git-send-email-hvaibhav@ti.com> <20121010140027.GB13724@beef> <79CD15C6BA57404B839C016229A409A83EB3B573@DBDE01.ent.ti.com> <20121010143501.GC13724@beef> <20121010143742.GE13724@beef> Message-ID: <20121016174319.GU15569@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Matt Porter [121010 07:38]: > On Wed, Oct 10, 2012 at 10:35:01AM -0400, Matt Porter wrote: > > On Wed, Oct 10, 2012 at 02:19:40PM +0000, Vaibhav Hiremath wrote: > > > On Wed, Oct 10, 2012 at 19:30:27, Porter, Matt wrote: > > > > On Tue, Oct 09, 2012 at 02:27:20PM +0530, Vaibhav Hiremath wrote: > > > > > With recent changes in omap gpmc driver code, in case of DT > > > > > boot mode, where bootloader does not configure gpmc cs space > > > > > will result into kernel BUG() inside gpmc_mem_init() function, > > > > > as gpmc cs0 gpmc_config7[0].csvalid bit is set to '1' and > > > > > gpmc_config7[0].baseaddress is set to '0' on reset. > > > > > > > > > > This use-case is applicable for any board/EVM which doesn't have > > > > > any peripheral connected to gpmc cs0, for example BeagleXM and > > > > > BeagleBone, so DT boot mode fails. > > > > > > > > > > This patch adds of_have_populated_dt() check before creating > > > > > device, so that for DT boot mode, gpmc probe will not be called > > > > > which is expected behavior, as gpmc is not supported yet from DT. > > > > > > > > > > Signed-off-by: Vaibhav Hiremath > > > > > Cc: Afzal Mohammed > > > > > Cc: Tony Lindgren > > > > > Cc Paul Walmsley > > > > > --- > > > > > This should go in for rc1, as this breaks AM33xx boot. > > > > > > > > Fixes BeagleBone on mainline. > > > > > > > > Tested-by: Matt Porter > > > > > > > > > > Thanks Matt and Afzal, > > > > > > Tony can this be picked up for rc1?? I know you have already sent pull > > > request for rc1, but by any chance you are planning to send another request? > > > > I also found a separate problem with the mcasp clock data that's needed > > for rc1. I just posted a patch for that as I need both this patch and the > > clock data fix to boot from current mainline. > > Disregard now that you got me pointed to the pull request with this :) Thanks applying $Subject patch into omap-for-v3.7-rc1/fixes-part2 and ignoring the comments about the mcasp clock as it sounds like the mcasp is already fixed. Regards, Tony