From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init()
Date: Tue, 16 Oct 2012 11:07:55 -0700 [thread overview]
Message-ID: <20121016180754.GB15569@atomide.com> (raw)
In-Reply-To: <50751D36.9020001@compulab.co.il>
* Igor Grinberg <grinberg@compulab.co.il> [121010 00:02]:
> On 10/09/12 22:29, Paul Walmsley wrote:
> >
> > Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move
> > debug_card_init() function") results in the following new sparse
> > warning:
> >
> > arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?
> >
> > Fix by implementing Tony's suggestion to add a "sideways include" to the
> > new location of the debug-devices.h file in arch/arm/mach-omap2/.
> >
> > Signed-off-by: Paul Walmsley <paul@pwsan.com>
> > Cc: Igor Grinberg <grinberg@compulab.co.il>
> > Cc: Tony Lindgren <tony@atomide.com>
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Thanks, applying into omap-for-v3.7-rc1/fixes-part2.
Regards,
Tony
> > ---
> > arch/arm/plat-omap/debug-devices.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/plat-omap/debug-devices.c b/arch/arm/plat-omap/debug-devices.c
> > index c7a4c09..5a4678e 100644
> > --- a/arch/arm/plat-omap/debug-devices.c
> > +++ b/arch/arm/plat-omap/debug-devices.c
> > @@ -16,6 +16,7 @@
> > #include <linux/smc91x.h>
> >
> > #include <mach/hardware.h>
> > +#include "../mach-omap2/debug-devices.h"
> >
> > /* Many OMAP development platforms reuse the same "debug board"; these
> > * platforms include H2, H3, H4, and Perseus2.
>
> --
> Regards,
> Igor.
prev parent reply other threads:[~2012-10-16 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 20:29 [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init() Paul Walmsley
2012-10-10 7:01 ` Igor Grinberg
2012-10-16 18:07 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016180754.GB15569@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).