linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: hwmod data: gpmc main clk
Date: Tue, 16 Oct 2012 11:12:05 -0700	[thread overview]
Message-ID: <20121016181204.GD15569@atomide.com> (raw)
In-Reply-To: <507BDECA.20101@ti.com>

* Benoit Cousson <b-cousson@ti.com> [121015 03:02]:
> Hi Afzal,
> 
> On 10/15/2012 07:47 AM, Afzal Mohammed wrote:
> > gpmc has been converted to a driver. It requests clock with
> > con-id "fck", if not available, probe fails. Clock for gpmc
> > device with con-id "fck" is created (aliased) along with
> > hwmod device, and for that to happen, main_clk needs to be
> > specified in hwmod entry, add it for OMAP4.
> 
> Well, in this case, this is not the preferred way. The hwmod data are supposed to reflect the real HW capabilities.
> We'd better add the alias in the already existing dummy clock node.
> 
> Here is the patch to do that.
> 
> Thanks,
> Benoit
> 
> ---
> From: Benoit Cousson <b-cousson@ti.com>
> Date: Mon, 15 Oct 2012 11:41:42 +0200
> Subject: [PATCH] ARM: OMAP2+: clock data: Add dev-id for the omap-gpmc dummy fck
> 
> The GPMC code has been converted to a driver by the following commit:
> 
>  commit da496873970c57c4b31e186d967933da0ffa0d7c
>  Author: Afzal Mohammed <afzal@ti.com>
>  Date:   Sun Sep 23 17:28:25 2012 -0600
> 
>    ARM: OMAP2+: gpmc: minimal driver support
> 
> It now requests a clock with con-id "fck" otherwise the probe will fails.
> 
> [    0.342010] omap-gpmc omap-gpmc: error: clk_get
> [    0.346771] omap-gpmc: probe of omap-gpmc failed with error -2
> 
> Add the "omap-gmpc" dev-id and fck con-id to the already existing
> gmpc-fck dummy clock.
> 
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Afzal Mohammed <afzal@ti.com>

Thanks applying into omap-for-v3.7-rc1/fixes-part2.

Regards,

Tony

> ---
>  arch/arm/mach-omap2/clock44xx_data.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
> index d661d13..6efc30c 100644
> --- a/arch/arm/mach-omap2/clock44xx_data.c
> +++ b/arch/arm/mach-omap2/clock44xx_data.c
> @@ -3294,7 +3294,7 @@ static struct omap_clk omap44xx_clks[] = {
>  	CLK(NULL,	"auxclk5_src_ck",		&auxclk5_src_ck,	CK_443X),
>  	CLK(NULL,	"auxclk5_ck",			&auxclk5_ck,	CK_443X),
>  	CLK(NULL,	"auxclkreq5_ck",		&auxclkreq5_ck,	CK_443X),
> -	CLK(NULL,	"gpmc_ck",			&dummy_ck,	CK_443X),
> +	CLK("omap-gpmc",	"fck",				&dummy_ck,	CK_443X),
>  	CLK("omap_i2c.1",	"ick",				&dummy_ck,	CK_443X),
>  	CLK("omap_i2c.2",	"ick",				&dummy_ck,	CK_443X),
>  	CLK("omap_i2c.3",	"ick",				&dummy_ck,	CK_443X),
> -- 
> 1.7.0.4
> 

      reply	other threads:[~2012-10-16 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15  5:47 [PATCH] ARM: OMAP4: hwmod data: gpmc main clk Afzal Mohammed
2012-10-15 10:00 ` Benoit Cousson
2012-10-16 18:12   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121016181204.GD15569@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).