From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: OMAP2+: gpmc: Fix kernel BUG for DT boot mode
Date: Wed, 17 Oct 2012 09:13:48 -0700 [thread overview]
Message-ID: <20121017161348.GT15569@atomide.com> (raw)
In-Reply-To: <507EC395.7060409@ti.com>
* Jon Hunter <jon-hunter@ti.com> [121017 07:43]:
>
> On 10/16/2012 04:26 PM, Tony Lindgren wrote:
> > * Jon Hunter <jon-hunter@ti.com> [121016 14:00]:
> >> Hi Tony,
> >>
> >> On 10/16/2012 12:48 PM, Tony Lindgren wrote:
> >>> * Richard Cochran <richardcochran@gmail.com> [121015 12:18]:
> >>>> From: hvaibhav at ti.com <hvaibhav@ti.com>
> >>>>
> >>>> With recent changes in omap gpmc driver code, in case of DT
> >>>> boot mode, where bootloader does not configure gpmc cs space
> >>>> will result into kernel BUG() inside gpmc_mem_init() function,
> >>>> as gpmc cs0 gpmc_config7[0].csvalid bit is set to '1' and
> >>>> gpmc_config7[0].baseaddress is set to '0' on reset.
> >>>>
> >>>> This use-case is applicable for any board/EVM which doesn't have
> >>>> any peripheral connected to gpmc cs0, for example BeagleXM and
> >>>> BeagleBone, so DT boot mode fails.
> >>>>
> >>>> This patch adds of_have_populated_dt() check before creating
> >>>> device, so that for DT boot mode, gpmc probe will not be called
> >>>> which is expected behavior, as gpmc is not supported yet from DT.
> >>>
> >>> I'm applying this one into omap-for-v3.7-rc1/fixes-part2.
> >>>
> >>> Next time, please also cc linux-omap at vger.kernel.org for series
> >>> like this. I'm sure the people reading the omap list are interested
> >>> in these.
> >>
> >> This patch appears to be masking an underlying issue. How about
> >> something like the following ...
> >
> > OK that looks good to me. I'll drop the earlier fix and use
> > yours instead.
>
> Hi Tony, sorry but I realised now that in my patch that I need to
> take care of releasing and memory and clocks that were acquired
> during the probe. Here is a V2. If you prefer I can create a delta
> patch also with the previous.
OK thanks I'll update it.
Regards,
Tony
next prev parent reply other threads:[~2012-10-17 16:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 19:16 [PATCH 0/5] am335x fixes for 3.7-rc2 Richard Cochran
2012-10-15 19:16 ` [PATCH 1/5] ARM: OMAP2+: gpmc: Fix kernel BUG for DT boot mode Richard Cochran
2012-10-16 17:48 ` Tony Lindgren
2012-10-16 20:58 ` Jon Hunter
2012-10-16 21:26 ` Tony Lindgren
2012-10-17 14:41 ` Jon Hunter
2012-10-17 16:13 ` Tony Lindgren [this message]
2012-10-16 19:47 ` Jon Hunter
2012-10-18 16:16 ` Hiremath, Vaibhav
2012-10-18 16:42 ` Jon Hunter
2012-10-18 18:04 ` Hiremath, Vaibhav
2012-10-18 18:30 ` Jon Hunter
2012-10-18 18:39 ` Hiremath, Vaibhav
2012-10-18 18:46 ` Jon Hunter
2012-10-15 19:16 ` [PATCH 2/5] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio Richard Cochran
2012-10-16 17:50 ` Tony Lindgren
2012-10-15 19:16 ` [PATCH 3/5] net: davinci_mdio: Fix type mistake in calling runtime-pm api Richard Cochran
2012-10-18 16:13 ` Hiremath, Vaibhav
2012-10-15 19:16 ` [PATCH 4/5] net: cpsw: Add parent<->child relation support between cpsw and mdio Richard Cochran
2012-10-18 16:13 ` Hiremath, Vaibhav
2012-10-15 19:16 ` [PATCH 5/5] arm/dts: am33xx: Add cpsw and mdio module nodes for AM33XX Richard Cochran
2012-10-16 17:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017161348.GT15569@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).