From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg
Date: Wed, 17 Oct 2012 20:13:01 +0100 [thread overview]
Message-ID: <20121017191300.GL21164@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <005801cdac56$8da0c120$a8e24360$%kim@samsung.com>
On Wed, Oct 17, 2012 at 08:00:00PM +0900, Kukjin Kim wrote:
> > +static int samsung_usbphy_get_refclk_freq(struct samsung_usbphy *sphy)
> > +{
> > + struct clk *ref_clk;
> > + int refclk_freq = 0;
> > +
> > + ref_clk = clk_get(sphy->dev, "xusbxti");
> > + if (IS_ERR(ref_clk)) {
>
> IS_ERR_OR_NULL(ref_clk)?
For the N'th time, NO. IS_ERR is correct here.
> > + dev_err(sphy->dev, "Failed to get reference clock\n");
> > + return PTR_ERR(ref_clk);
Look, it's the ABI. Not only that but it's also TOTALLY AND UTTERLY WRONG
to use IS_ERR_OR_NULL(foo) and then follow it with return PTR_ERR(foo).
You end up returning ZERO.
Stop telling people to use IS_ERR_OR_NULL without properly thinking about
it first. Virtually every single one of these done this way is a BUG.
Are we clear on this?
next prev parent reply other threads:[~2012-10-17 19:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 12:54 [PATCH v6 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg Praveen Paneri
2012-09-24 9:38 ` Praveen Paneri
2012-09-24 10:39 ` ABRAHAM, KISHON VIJAY
2012-09-25 11:29 ` Marc Kleine-Budde
2012-09-26 7:22 ` Praveen Paneri
2012-10-03 9:26 ` [PATCH " Praveen Paneri
2012-10-12 10:15 ` [PATCH] " Praveen Paneri
2012-10-15 13:28 ` Felipe Balbi
2012-10-15 13:44 ` Kyungmin Park
2012-10-16 5:39 ` Praveen Paneri
2012-10-20 19:19 ` Pavel Machek
2012-10-22 5:43 ` Praveen Paneri
2012-10-17 11:00 ` Kukjin Kim
2012-10-17 12:30 ` Praveen Paneri
2012-10-17 19:13 ` Russell King - ARM Linux [this message]
2012-10-21 7:16 ` Domenico Andreoli
2012-09-24 10:41 ` [PATCH v6 1/5] " Kyungmin Park
2012-09-24 13:04 ` Rob Herring
2012-09-25 11:23 ` Praveen Paneri
2012-09-25 12:18 ` Rob Herring
2012-09-25 13:17 ` ABRAHAM, KISHON VIJAY
2012-09-26 7:14 ` Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 2/5] usb: s3c-hsotg: Adding phy driver support Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 3/5] ARM: S3C64XX: Removing old phy setup code Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 4/5] ARM: S3C64XX: Enabling samsung-usbphy driver Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 5/5] ARM: Exynos4210: " Praveen Paneri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017191300.GL21164@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).