From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: kirkwood: use gpio-fan DT binding on lsxl
Date: Sun, 21 Oct 2012 08:55:52 +0200 [thread overview]
Message-ID: <20121021065552.GH21046@lunn.ch> (raw)
In-Reply-To: <1350776094-16778-2-git-send-email-michael@walle.cc>
On Sun, Oct 21, 2012 at 01:34:54AM +0200, Michael Walle wrote:
> Remove board specific gpio-fan driver registration. Moved into device tree.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 ++++++++
> arch/arm/mach-kirkwood/board-lsxl.c | 47 ----------------------------------
> 2 files changed, 11 insertions(+), 47 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> index 8fea375..798e60e 100644
> --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> @@ -94,4 +94,15 @@
> gpios = <&gpio1 16 1>;
> };
> };
> +
> + gpio_fan {
> + compatible = "gpio-fan";
> + gpios = <&gpio0 19 1
> + &gpio0 18 1>;
> + gpio-fan,speed-map = <0 3
> + 1500 2
> + 3250 1
> + 5000 0>;
> + alarm-gpios = <&gpio1 8 0>;
> + };
> };
> diff --git a/arch/arm/mach-kirkwood/board-lsxl.c b/arch/arm/mach-kirkwood/board-lsxl.c
> index 64e5cc6..7e18cad 100644
> --- a/arch/arm/mach-kirkwood/board-lsxl.c
> +++ b/arch/arm/mach-kirkwood/board-lsxl.c
> @@ -16,7 +16,6 @@
> #include <linux/platform_device.h>
> #include <linux/mv643xx_eth.h>
> #include <linux/gpio.h>
> -#include <linux/gpio-fan.h>
> #include "common.h"
> #include "mpp.h"
Hi Michael
You might also be able to remove platform_device.h.
Otherwise, it looks good.
Andrew
next prev parent reply other threads:[~2012-10-21 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 23:34 [PATCH 1/2] ARM: kirkwood: cleanup lsxl board includes Michael Walle
2012-10-20 23:34 ` [PATCH 2/2] ARM: kirkwood: use gpio-fan DT binding on lsxl Michael Walle
2012-10-21 6:55 ` Andrew Lunn [this message]
2012-10-21 13:59 ` Michael Walle
2012-10-21 17:59 ` Andrew Lunn
2012-10-22 3:07 ` Jason Cooper
2012-10-22 3:06 ` [PATCH 1/2] ARM: kirkwood: cleanup lsxl board includes Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121021065552.GH21046@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).