From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] arm:socfpga: Enable SMP for socfpga
Date: Thu, 25 Oct 2012 00:57:35 +0200 [thread overview]
Message-ID: <20121025005735.35b9f971@skate> (raw)
In-Reply-To: <1350581567-17229-1-git-send-email-dinguyen@altera.com>
Dear dinguyen at altera.com,
On Thu, 18 Oct 2012 11:32:47 -0600, dinguyen at altera.com wrote:
> +static int __cpuinit socfpga_boot_secondary(unsigned int cpu, struct task_struct *idle)
> +{
> + int trampoline_size = &secondary_trampoline_end - &secondary_trampoline;
> +
> + memcpy(phys_to_virt(0), &secondary_trampoline, trampoline_size);
> +
> + __raw_writel(virt_to_phys(secondary_startup), (sys_manager_base_addr+0x10));
> +
> + pen_release = 0;
Are you sure that this code builds? In your v1, this variable was
declared in your assembly file, but it is no longer here, and you
mention in your changelog that it has been removed. But not completely
apparently.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-24 22:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 17:32 [PATCHv2] arm:socfpga: Enable SMP for socfpga dinguyen at altera.com
2012-10-24 22:43 ` Pavel Machek
2012-10-24 22:57 ` Thomas Petazzoni [this message]
2012-10-25 16:21 ` Dinh Nguyen
2012-10-24 23:01 ` Rob Herring
2012-10-25 16:25 ` Dinh Nguyen
2012-10-25 15:41 ` Rob Herring
2012-10-25 17:49 ` Dinh Nguyen
2012-10-27 11:43 ` ERRATA_751472 was " Pavel Machek
2012-10-25 13:56 ` Arnd Bergmann
2012-10-25 16:29 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025005735.35b9f971@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).