Question about move atmel audio part to DT support

Question about move atmel audio part to DT support

[Bo Shen]

Cc:
    linux-arm-kernel mailing list
    devicetree-discuss mailing list
    alsa-devel mailing list
    linux-sound mailing list


On 10/19/2012 14:38, Bo Shen wrote:
> Hi Mark Brown,
>    Now, I am trying to move atmel audio part to DT support. I meet the
> following issue.
>
>    Atmel audio part has three platform device:
>      -> atmel ssc: ssc library (different SOC has different number)
>      -> atmel ssc dai: dai for audio
>      -> atmel pcm: for pdc or dma transfer (now only support pdc, dma
> support will add soon)
>
>   In DT support kernel, I don't find any similar case. So, if I want to
> keep ssc as library, and use dai to register pcm. Then the dts file will
> like:
> ---<8---
> ssc0: ssc at fffbc000 {
>                  status = "okay";
> };
>
> dai0: dai {
>                  compatible = "atmel,atmel-ssc-dai";
>          };
>
> sound {
>                  compatible = "atmel,at91sam9g20-audio";
>                  atmel,model = "wm8731 @ sam9g20ek";
>
>                  atmel,audio-routing =
>                          "Ext Spk", "LHPOUT",
>                          "Int Mic", "MICIN";
>
>                  atmel,audio-codec = <&wm8731>;
>                  atmel,dai = <&dai>;
> };
> --->8---
>
>    Would this be OK?
>    If not, may I add some code for ssc which dedicate for audio into
> sound/soc/atmel (using audio-ssc and ssc to distiguish which dedicate
> for audio, which used for ssc library)? This will broken the exist code
> for audio (only sam9g20-wm8731).
>    Any suggestion?

Question about move atmel audio part to DT support

[Mark Brown]

On Fri, Oct 19, 2012 at 04:18:16PM +0800, Bo Shen wrote:

> Cc:
>    linux-arm-kernel mailing list
>    devicetree-discuss mailing list
>    alsa-devel mailing list
>    linux-sound mailing list

Better to resend for things like this rather than double quote.

> 
> >   Atmel audio part has three platform device:
> >     -> atmel ssc: ssc library (different SOC has different number)
> >     -> atmel ssc dai: dai for audio
> >     -> atmel pcm: for pdc or dma transfer (now only support pdc, dma
> >support will add soon)

> >  In DT support kernel, I don't find any similar case. So, if I want to
> >keep ssc as library, and use dai to register pcm. Then the dts file will
> >like:

I'm not seeing anything at all unusual about the above situation - it'd
help if you could explain what you think is complex here?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121025/475b32d6/attachment.sig>

Question about move atmel audio part to DT support

[Bo Shen]

Hi Mark,

On 10/26/2012 0:40, Mark Brown wrote:
> On Fri, Oct 19, 2012 at 04:18:16PM +0800, Bo Shen wrote:
>
>> Cc:
>>     linux-arm-kernel mailing list
>>     devicetree-discuss mailing list
>>     alsa-devel mailing list
>>     linux-sound mailing list
>
> Better to resend for things like this rather than double quote.

Got it. Thanks.

>>
>>>    Atmel audio part has three platform device:
>>>      -> atmel ssc: ssc library (different SOC has different number)
>>>      -> atmel ssc dai: dai for audio
>>>      -> atmel pcm: for pdc or dma transfer (now only support pdc, dma
>>> support will add soon)
>
>>>   In DT support kernel, I don't find any similar case. So, if I want to
>>> keep ssc as library, and use dai to register pcm. Then the dts file will
>>> like:
>
> I'm not seeing anything at all unusual about the above situation - it'd
> help if you could explain what you think is complex here?

This is only a little different with others. We have one more DT node: 
dai in dts file. I am worry about this won't be acceptable.

Anyway, I have sent out the patches. Please help review the code if 
possible.
Thanks.

BRs,
Bo Shen