From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 25 Oct 2012 09:56:44 -0700 Subject: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h In-Reply-To: <1466344.HbU9q5zM1q@avalon> References: <20121025001913.2082.31062.stgit@muffinssi.local> <20121025002056.2082.45221.stgit@muffinssi.local> <1466344.HbU9q5zM1q@avalon> Message-ID: <20121025165643.GP11928@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Laurent Pinchart [121025 01:39]: > > I still think you should split this in two files, omap-iommu.h and omap- > iovmm.h. The later would just be arch/arm/plat-omap/include/plat/iovmm.h moved > to include/linux.h. Can you please explain a bit more why you're thinking a separate omap-iovmm.h is needed in addtion to omap-iommu.h? My reasoning for not adding it is that neither intel nor amd needs more than intel-iommu.h and amd-iommu.h. And hopefully the iommu framework will eventually provide the API needed. And I'd rather not be the person introducing this second new file into include/linux :) Joerg and Ohad, do you have any opinions on this? Regards, Tony