From mboxrd@z Thu Jan 1 00:00:00 1970 From: nm@ti.com (Nishanth Menon) Date: Thu, 25 Oct 2012 17:27:34 -0500 Subject: [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message In-Reply-To: <20121025221236.GE11928@atomide.com> References: <1351186501-32223-1-git-send-email-khilman@deeprootsystems.com> <20121025175607.GA21937@kahuna> <20121025221236.GE11928@atomide.com> Message-ID: <20121025222733.GA19767@kahuna> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 15:12-20121025, Tony Lindgren wrote: > * Nishanth Menon [121025 10:57]: > > On 10:35-20121025, Kevin Hilman wrote: > > > From: Kevin Hilman [..] > > while we are at it, could we clean up the pr_warning usage back to > > pr_warn as well? > > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c > > index 880249b..2d66f8c 100644 > > --- a/arch/arm/mach-omap2/vc.c > > +++ b/arch/arm/mach-omap2/vc.c > > @@ -186,7 +186,7 @@ int omap_vc_bypass_scale(struct voltagedomain *voltdm, > > loop_cnt++; > > > > if (retries_cnt > 10) { > > - pr_warning("%s: Retry count exceeded\n", __func__); > > + pr_warn("%s: Retry count exceeded\n", __func__); > > return -ETIMEDOUT; > > } > > > > Looks like that's in the separate patch you posted for v3.8 that Kevin > is taking. Nope. if you indicated [1], then I got inspired by Kevin's cleanup and cleaned up vp.c -> Kevin cleaned up vc.c :) If the additional cleanup I pointed above in this thread is interesting, it could be clubbed with the current patch itself [1] https://patchwork.kernel.org/patch/1646661/ -- Regards, Nishanth Menon