linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sebastian@breakpoint.cc (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] USB: doc: Binding document for ehci-platform driver
Date: Fri, 26 Oct 2012 10:02:54 +0200	[thread overview]
Message-ID: <20121026080254.GD3009@breakpoint.cc> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1210251035270.1278-100000@iolanthe.rowland.org>

On Thu, Oct 25, 2012 at 10:36:14AM -0400, Alan Stern wrote:
> What happens if the drivers get probed in the wrong order?  That is, if 
> ehci-platform gets probed before ehci-spear (or whatever)?

The "wrong" driver may get loaded. Right now, you should have them all in
one driver. For instance the crypto node in mpc8315erdb.dts:
|   crypto at 30000 {
|           compatible = "fsl,sec3.3", "fsl,sec3.1", "fsl,sec3.0",
|                        "fsl,sec2.4", "fsl,sec2.2", "fsl,sec2.1",
|                        "fsl,sec2.0";
?

The higher the version, the more features are available by the hardware.
The driver [0] probes only for "fsl,sec2.0" but it uses
of_device_is_compatible() to check for the other entries. You could also add
all 7 compatible entries to the driver and distinguish them by the driver_data
field. This is an implementation detail.
However, having two drivers, one for "fsl,sec3.3" and one for "fsl,sec2.0",
would "randomly" load one of the two driver depending on link order and so on.

[0] drivers/crypto/talitos.c

> 
> Alan Stern
> 

Sebastian

  reply	other threads:[~2012-10-26  8:02 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-20 22:10 [PATCH v2 0/2] Update ehci-platform driver to support devicetree Tony Prisk
2012-10-20 22:10 ` [PATCH v2 1/2] USB: Update EHCI-platform driver to devicetree Tony Prisk
2012-10-21  2:02   ` Alan Stern
2012-10-20 22:10 ` [PATCH v2 2/2] USB: doc: Binding document for ehci-platform driver Tony Prisk
2012-10-21 17:34   ` Florian Fainelli
2012-10-22 16:07   ` Stephen Warren
2012-10-22 17:34     ` Alan Stern
2012-10-22 17:48       ` Stephen Warren
2012-10-22 19:00         ` Alan Stern
2012-10-22 22:10           ` Stephen Warren
2012-10-23 14:10             ` Alan Stern
2012-10-23 16:15               ` Stephen Warren
2012-10-23 17:59                 ` Alan Stern
2012-10-23 18:47                   ` Stephen Warren
2012-10-23 19:33                     ` Alan Stern
2012-10-23 20:06                       ` Rob Herring
2012-10-24 14:57                         ` Alan Stern
2012-10-24 15:26                           ` Sebastian Andrzej Siewior
2012-10-24 16:16                             ` Stephen Warren
2012-10-24 16:36                               ` Florian Fainelli
2012-10-24 16:38                               ` Alan Stern
2012-10-24 16:44                                 ` Florian Fainelli
2012-10-24 18:04                                   ` Alan Stern
2012-10-24 18:18                                     ` Florian Fainelli
2012-10-24 16:45                                 ` Stephen Warren
2012-10-24 17:46                                   ` Alan Stern
2012-10-24 18:09                                     ` Stephen Warren
2012-10-24 18:55                                       ` Mitch Bradley
2012-10-24 19:30                                         ` Alan Stern
2012-10-25 10:23                                         ` Sebastian Andrzej Siewior
2012-10-25 14:36                                           ` Alan Stern
2012-10-26  8:02                                             ` Sebastian Andrzej Siewior [this message]
2012-10-26 14:54                                               ` Alan Stern
2012-10-25 15:53                                           ` Stephen Warren
2012-10-24 19:41                                       ` Alan Stern
2012-10-24 16:44                               ` Alan Stern
2012-10-24 16:48                                 ` Stephen Warren
2012-10-24 17:42                                 ` Rob Herring
2012-10-24 17:57                                   ` Alan Stern
2012-10-24 16:28                           ` Stephen Warren
2012-10-24 16:54                             ` Alan Stern
2012-10-24 17:37                               ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026080254.GD3009@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).