linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 06/14] mtd: onenand: omap: use pdata info instead of cpu_is
Date: Fri, 26 Oct 2012 09:41:15 -0700	[thread overview]
Message-ID: <20121026164115.GE11908@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210260411140.27963@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [121025 22:05]:
> On Fri, 26 Oct 2012, Paul Walmsley wrote:
> 
> > On Mon, 8 Oct 2012, Afzal Mohammed wrote:
> > 
> > > platform data now contains a field to indicate whether
> > > soc belongs to omap34xx family, use it instead of
> > > cpu_is_* check.
> > > 
> > > This helps in removing dependency of platform specific
> > > header file - cpu.h
> > > 
> > > Signed-off-by: Afzal Mohammed <afzal@ti.com>
> > 
> > This one breaks an N800 multi-OMAP build here:
> 
> It also breaks an OMAP3+4 config:
> 
> drivers/built-in.o: In function `omap2_onenand_probe':
> /home/paul/test_build/temp/test_cleanup_prcm_8634155e_with_fixes/20121025214236/linux/drivers/mtd/onenand/omap2.c:742: 
> undefined reference to `omap2_onenand_read_bufferram'
> /home/paul/test_build/temp/test_cleanup_prcm_8634155e_with_fixes/20121025214236/linux/drivers/mtd/onenand/omap2.c:743: 
> undefined reference to `omap2_onenand_write_bufferram'
> /home/paul/test_build/temp/test_cleanup_prcm_8634155e_with_fixes/20121025214236/linux/drivers/mtd/onenand/omap2.c:742: 
> undefined reference to `omap2_onenand_read_bufferram'
> /home/paul/test_build/temp/test_cleanup_prcm_8634155e_with_fixes/20121025214236/linux/drivers/mtd/onenand/omap2.c:743: 
> undefined reference to `omap2_onenand_write_bufferram'
> 
> Fix below.

Thanks, I'd like to pull this fix in too along with the
others.

Regards,

Tony


 
>  drivers/mtd/onenand/omap2.c |   18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index f87cf39..99f96e1 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -555,13 +555,19 @@ static int omap2_onenand_write_bufferram(struct mtd_info *mtd, int area,
>  
>  #else
>  
> -int omap2_onenand_read_bufferram(struct mtd_info *mtd, int area,
> -				 unsigned char *buffer, int offset,
> -				 size_t count);
> +static int omap2_onenand_read_bufferram(struct mtd_info *mtd, int area,
> +					unsigned char *buffer, int offset,
> +					size_t count)
> +{
> +	return -ENOSYS;
> +}
>  
> -int omap2_onenand_write_bufferram(struct mtd_info *mtd, int area,
> -				  const unsigned char *buffer,
> -				  int offset, size_t count);
> +static int omap2_onenand_write_bufferram(struct mtd_info *mtd, int area,
> +					 const unsigned char *buffer,
> +					 int offset, size_t count)
> +{
> +	return -ENOSYS;
> +}
>  
>  #endif
>  
> -- 
> 1.7.10.4

  reply	other threads:[~2012-10-26 16:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08  5:35 [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage Afzal Mohammed
2012-10-08  5:36 ` [PATCH v2 01/14] ARM: OMAP2+: gpmc: annotate exit sections properly Afzal Mohammed
2012-10-08  5:36 ` [PATCH v2 02/14] mtd: onenand: omap: cleanup gpmc dependency Afzal Mohammed
2012-10-08  5:36 ` [PATCH v2 03/14] mtd: nand: omap: free region as per resource size Afzal Mohammed
2012-10-08  5:37 ` [PATCH v2 04/14] mtd: nand: omap: read nand using register address Afzal Mohammed
2012-10-08  5:37 ` [PATCH v2 05/14] ARM: OMAP2+: onenand: connected soc info in pdata Afzal Mohammed
2012-10-08  5:37 ` [PATCH v2 06/14] mtd: onenand: omap: use pdata info instead of cpu_is Afzal Mohammed
2012-10-26  1:48   ` Paul Walmsley
2012-10-26  5:04     ` Paul Walmsley
2012-10-26 16:41       ` Tony Lindgren [this message]
2012-10-29  8:06         ` Afzal Mohammed
2012-10-26 16:40     ` Tony Lindgren
2012-10-08  5:37 ` [PATCH v2 07/14] ARM: OMAP2+: onenand: header cleanup Afzal Mohammed
2012-10-08  5:37 ` [PATCH v2 08/14] ARM: OMAP2+: nand: " Afzal Mohammed
2012-10-08  5:37 ` [PATCH v2 09/14] mtd: nand: omap: bring in gpmc nand macros Afzal Mohammed
2012-10-08  5:37 ` [PATCH v2 10/14] ARM: OMAP2+: nand: bch capability check Afzal Mohammed
2012-10-08  5:37 ` [PATCH v2 11/14] ARM: OMAP2+: gpmc: nand register helper bch update Afzal Mohammed
2012-10-08  5:37 ` [PATCH v2 12/14] mtd: nand: omap: handle gpmc bch[48] Afzal Mohammed
2012-10-08  5:38 ` [PATCH v2 13/14] ARM: OMAP2+: gpmc: remove exported nand functions Afzal Mohammed
2012-10-08  5:38 ` [PATCH v2 14/14] ARM: OMAP2+: gpmc: localize gpmc header Afzal Mohammed
2012-10-08  6:08 ` [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage Mohammed, Afzal
2012-10-10 16:38   ` Ivan Djelic
2012-10-11  5:24     ` Mohammed, Afzal
2012-10-16 18:06     ` Tony Lindgren
2012-10-17  5:29       ` Afzal Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026164115.GE11908@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).