From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: socfpga: fix build break for allyesconfig
Date: Fri, 26 Oct 2012 22:51:36 +0100 [thread overview]
Message-ID: <20121026215136.GC21164@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1351289861-16297-1-git-send-email-dinguyen@altera.com>
On Fri, Oct 26, 2012 at 04:17:41PM -0600, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Add check for armv7 in headsmp.S.
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> ---
> arch/arm/mach-socfpga/headsmp.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-socfpga/headsmp.S b/arch/arm/mach-socfpga/headsmp.S
> index 17d6eaf..9031a3c 100644
> --- a/arch/arm/mach-socfpga/headsmp.S
> +++ b/arch/arm/mach-socfpga/headsmp.S
> @@ -15,8 +15,10 @@
> #define CPU1_START_ADDR 0xffd08010
>
> ENTRY(secondary_trampoline)
> +#if __LINUX_ARM_ARCH__ >= 7
> movw r0, #:lower16:CPU1_START_ADDR
> movt r0, #:upper16:CPU1_START_ADDR
> +#endif
If you do that, then it effectively means you don't need these instructions
and you might as well just delete them... but looking at the following one:
> ldr r1, [r0]
it's clear that you do need it. So you need to find a different solution.
If the above assembly file can only run on ARMv7, consider putting
.march armv7
or similar before it.
next prev parent reply other threads:[~2012-10-26 21:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 22:17 [PATCH] arm: socfpga: fix build break for allyesconfig dinguyen at altera.com
2012-10-26 21:26 ` Arnd Bergmann
2012-10-26 21:51 ` Russell King - ARM Linux [this message]
2012-10-26 22:36 ` Pavel Machek
2012-10-26 22:43 ` Russell King - ARM Linux
2012-10-26 23:00 ` Pavel Machek
2012-10-27 10:43 ` Arnd Bergmann
2012-10-27 11:24 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026215136.GC21164@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).