From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ASoC: sam9g20_wm8731: convert to device tree support
Date: Sat, 27 Oct 2012 23:12:05 +0100 [thread overview]
Message-ID: <20121027221204.GL4564@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1350901079-18307-4-git-send-email-voice.shen@atmel.com>
On Mon, Oct 22, 2012 at 06:17:58PM +0800, Bo Shen wrote:
> Covert sam9g20 wm8731 to device tree support
> And enable it through dts file
>
> Tested on sam9g20 EK board
This needs to add binding documentation for the board.
> + dai: dai {
> + compatible = "atmel,atmel-ssc-dai";
> + atmel,dai-master = <&ssc0>;
> + };
This looks wrong - this is a Linux-specific virtual device sitting on
top of the SSC which is the actual physical device. The usual patterns
would be something like have the machine driver register the DAI based
on the SSC specified in the bindings (much like how you're handling the
platform already).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121027/9129200a/attachment.sig>
next prev parent reply other threads:[~2012-10-27 22:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 10:17 [PATCH 1/5] ARM: at91: atmel-ssc: add platform device id table Bo Shen
2012-10-22 10:17 ` [PATCH 2/5] ARM: at91: atmel-ssc: add device tree support Bo Shen
2012-10-30 17:13 ` Nicolas Ferre
2012-10-22 10:17 ` [PATCH 3/5] ASoC: atmel-ssc-dai: register 'platform' from DAIs Bo Shen
2012-10-22 10:17 ` [PATCH 4/5] ASoC: sam9g20_wm8731: convert to device tree support Bo Shen
2012-10-27 22:12 ` Mark Brown [this message]
2012-10-29 6:38 ` Bo Shen
2012-10-22 10:17 ` [PATCH 5/5] ASoC: sam9g20_wm8731: fix the issue for non-DT kernel Bo Shen
2012-10-27 22:14 ` Mark Brown
2012-10-29 6:15 ` Bo Shen
2012-10-30 16:07 ` [PATCH 1/5] ARM: at91: atmel-ssc: add platform device id table Mark Brown
2012-10-30 17:14 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121027221204.GL4564@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).