linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: PXA: Zipit Z2: Change active_state of power button
Date: Sun, 28 Oct 2012 23:01:04 +0100	[thread overview]
Message-ID: <201210282301.04714.marex@denx.de> (raw)
In-Reply-To: <1351438555-4668-4-git-send-email-anarsoul@gmail.com>

Dear Vasily Khoruzhick,

> From: mcmajeres <mark@engine12.com>

Read [1]

> Otherwise userspace might be confused about button state
> 
> Signed-off-by: mcmajeres <mark@engine12.com>

Attribution of code shall be done only towards people known by their name.

> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
>  arch/arm/mach-pxa/z2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c
> index ce90fa9..fac7cba 100644
> --- a/arch/arm/mach-pxa/z2.c
> +++ b/arch/arm/mach-pxa/z2.c
> @@ -437,7 +437,7 @@ static struct gpio_keys_button z2_pxa_buttons[] = {
>  	{
>  		.code		= KEY_POWER,
>  		.gpio		= GPIO1_ZIPITZ2_POWER_BUTTON,
> -		.active_low	= 0,
> +		.active_low	= 1,
>  		.desc		= "Power Button",
>  		.wakeup		= 1,
>  		.type		= EV_KEY,

[1] http://lwn.net/Articles/195643/

Best regards,
Marek Vasut

  reply	other threads:[~2012-10-28 22:01 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28 15:35 [PATCH 1/5] ARM: PXA: Add z2-usb-switch driver Vasily Khoruzhick
2012-10-28 15:35 ` [PATCH 2/5] ARM: PXA: Zipit Z2: Add USB host and device support Vasily Khoruzhick
2012-10-28 21:59   ` Marek Vasut
2012-10-28 22:38     ` Vasily Khoruzhick
2012-10-28 22:43       ` Marek Vasut
2012-10-28 22:58       ` Daniel Mack
2012-10-29  9:33         ` Vasily Khoruzhick
2012-10-29  9:42           ` Daniel Mack
2012-10-29 10:07             ` Vasily Khoruzhick
2012-10-29 10:22               ` Marek Vasut
2012-10-29 10:26                 ` Vasily Khoruzhick
2012-10-29 10:44               ` Daniel Mack
2012-10-29 10:52                 ` Vasily Khoruzhick
2012-10-29 11:00                   ` Daniel Mack
2012-10-29 11:12                     ` Vasily Khoruzhick
2012-10-29 11:14                       ` Daniel Mack
2012-10-30 20:01                         ` Vasily Khoruzhick
2012-10-30 20:05                           ` Daniel Mack
2012-10-30 21:20                             ` Vasily Khoruzhick
2012-10-31 14:00                             ` Haojian Zhuang
2012-10-31 15:31                             ` Haojian Zhuang
2012-11-02 20:52                               ` Vasily Khoruzhick
2012-11-02 21:29                               ` Vasily Khoruzhick
2012-11-05 17:31                                 ` Vasily Khoruzhick
2012-12-04  8:30                                   ` Haojian Zhuang
2012-10-29 10:48               ` Daniel Mack
2012-10-28 15:35 ` [PATCH 3/5] ARM: PXA: Zipit Z2: Fix oops in z2_power_off Vasily Khoruzhick
2012-10-28 15:35 ` [PATCH 4/5] ARM: PXA: Zipit Z2: Change active_state of power button Vasily Khoruzhick
2012-10-28 22:01   ` Marek Vasut [this message]
2012-10-28 22:31     ` mark at engine12.com
2012-10-28 15:35 ` [PATCH 5/5] ARM: PXA: Zipit Z2: Fix backlight PWM device number Vasily Khoruzhick
2012-10-28 22:01   ` Marek Vasut
2012-10-28 22:23     ` Vasily Khoruzhick
2012-10-28 22:39       ` Marek Vasut
2012-10-28 15:39 ` [PATCH 1/5] ARM: PXA: Add z2-usb-switch driver Vasily Khoruzhick
2012-10-28 15:42   ` [PATCH v2 " Vasily Khoruzhick
2012-10-28 17:03     ` Marko Katić
2012-10-28 18:12       ` Vasily Khoruzhick
2012-10-28 21:57     ` Marek Vasut
2012-10-28 22:27       ` Vasily Khoruzhick
2012-10-28 22:38         ` Marek Vasut
2012-10-28 22:45           ` Vasily Khoruzhick
2012-10-28 22:48             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210282301.04714.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).