From: nbowler@elliptictech.com (Nick Bowler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: zynq: Allow UART1 to be used as DEBUG_LL console.
Date: Thu, 1 Nov 2012 14:39:21 -0400 [thread overview]
Message-ID: <20121101183921.GA32744@elliptictech.com> (raw)
In-Reply-To: <508FB9B1.5060404@monstr.eu>
On 2012-10-30 12:27 +0100, Michal Simek wrote:
> On 10/29/2012 07:19 PM, Nick Bowler wrote:
> > +#if IS_ENABLED(CONFIG_DEBUG_ZYNQ_UART1)
> > +# define LL_UART_PADDR UART1_PHYS
> > +# define LL_UART_VADDR UART_VIRT
> > +#else
> > +# define LL_UART_PADDR UART0_PHYS
> > +# define LL_UART_VADDR UART_VIRT
> > +#endif
>
> Probably no reason to setup LL_UART_VADDR on two lines.
> It is enough to set it up once.
>
> MINOR: It is just my personal preference to use different coding style.
>
> #if IS_ENABLED(CONFIG_DEBUG_ZYNQ_UART1)
> # define LL_UART_PADDR UART1_PHYS
> #else
> # define LL_UART_PADDR UART0_PHYS
> #endif
>
> #define LL_UART_VADDR UART_VIRT
I have no strong feeling either way, so I will send v3 with these
changes.
Thanks,
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
prev parent reply other threads:[~2012-11-01 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 18:19 [PATCH v2] ARM: zynq: Allow UART1 to be used as DEBUG_LL console Nick Bowler
2012-10-30 11:27 ` Michal Simek
2012-11-01 18:39 ` Nick Bowler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101183921.GA32744@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).