linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] rtc: i.MX dryice: Add devicetree support
Date: Fri, 2 Nov 2012 09:56:05 +0100	[thread overview]
Message-ID: <20121102085605.GG1641@pengutronix.de> (raw)
In-Reply-To: <1348566986-9603-1-git-send-email-s.hauer@pengutronix.de>

Alessandro,

Everything fine with this patch? If yes, could you apply it?

Thanks
 Sascha

On Tue, Sep 25, 2012 at 11:56:26AM +0200, Sascha Hauer wrote:
> Add devicetree probing, fixing some whitespace damage along the way.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> 
> changes since v1:
> 
> - document 'intrerrupts' property as mandatory, because the driver needs it.
> 
>  Documentation/devicetree/bindings/rtc/imx-di.txt |   19 +++++++++++++++++++
>  drivers/rtc/rtc-imxdi.c                          |   12 +++++++++---
>  2 files changed, 28 insertions(+), 3 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/imx-di.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/imx-di.txt b/Documentation/devicetree/bindings/rtc/imx-di.txt
> new file mode 100644
> index 0000000..42b92b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/imx-di.txt
> @@ -0,0 +1,19 @@
> +* i.MX25 dryice Real Time Clock controller
> +
> +This RTC is part of the i.MX25 dryice module. Documentation for this
> +unit is not publically available. This binding only makes use of the
> +RTC.
> +
> +Required properties:
> +- compatible: should be "fsl,imx25-rtc"
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +- interrupts: interrupt source for the dryice module
> +
> +Example:
> +
> +	dryice at 53ffc000 {
> +		compatible = "fsl,imx25-dryice", "fsl,imx25-rtc";
> +		reg = <0x53ffc000 0x4000>;
> +		interrupts = <25>;
> +	};
> diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c
> index 891cd6c..b2fe920 100644
> --- a/drivers/rtc/rtc-imxdi.c
> +++ b/drivers/rtc/rtc-imxdi.c
> @@ -493,11 +493,17 @@ static int __devexit dryice_rtc_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct of_device_id of_dryice_rtc_match[] = {
> +	{ .compatible = "fsl,imx25-rtc", },
> +	{ },
> +};
> +
>  static struct platform_driver dryice_rtc_driver = {
>  	.driver = {
> -		   .name = "imxdi_rtc",
> -		   .owner = THIS_MODULE,
> -		   },
> +		.name = "imxdi_rtc",
> +		.owner = THIS_MODULE,
> +		.of_match_table = of_dryice_rtc_match,
> +	},
>  	.remove = __devexit_p(dryice_rtc_remove),
>  };
>  
> -- 
> 1.7.10.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      parent reply	other threads:[~2012-11-02  8:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25  9:56 [PATCH v2] rtc: i.MX dryice: Add devicetree support Sascha Hauer
2012-09-25 11:28 ` Shawn Guo
2012-11-02  8:56 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121102085605.GG1641@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).