From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip
Date: Fri, 2 Nov 2012 12:15:56 +0000 [thread overview]
Message-ID: <20121102121556.GV21164@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121101232010.78269291@skate>
On Thu, Nov 01, 2012 at 11:20:10PM +0100, Thomas Petazzoni wrote:
> Linus,
>
> On Thu, 1 Nov 2012 22:28:49 +0100, Linus Walleij wrote:
>
> > +void fpga_handle_irq(struct pt_regs *regs);
>
> This function does not need to be exposed in a public header: as
> proposed for the bcm2835 and armada-370-xp IRQ controller drivers, the
> driver should directly do handle_arch_irq = fpga_handle_irq, and
> therefore there is no need for the machine desc structure to reference
> fpga_handle_irq anymore.
Err no, then you don't understand what's going on here. This may or may
not be a top-level IRQ handler. Some ARM platforms have three of these
cascaded, others have one of these cascaded off a VIC or GIC.
To override the top level IRQ handler unconditionally is going to break
platforms.
next prev parent reply other threads:[~2012-11-02 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 21:28 [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip Linus Walleij
2012-11-01 22:20 ` Thomas Petazzoni
2012-11-02 12:15 ` Russell King - ARM Linux [this message]
2012-11-05 21:48 ` Rob Herring
2012-11-05 22:42 ` Arnd Bergmann
2012-11-05 23:14 ` Russell King - ARM Linux
2012-11-06 14:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102121556.GV21164@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).