From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sun, 4 Nov 2012 22:32:15 +0000 Subject: [PATCH V6 3/6] arm: cache-l2x0: add support for Aurora L2 cache ctrl In-Reply-To: <5086700E.10702@free-electrons.com> References: <1348738523-28609-1-git-send-email-gregory.clement@free-electrons.com> <1348738523-28609-2-git-send-email-gregory.clement@free-electrons.com> <20121023090154.GP21164@n2100.arm.linux.org.uk> <508666A6.9040701@free-electrons.com> <20121023100057.GS21164@n2100.arm.linux.org.uk> <5086700E.10702@free-electrons.com> Message-ID: <20121104223215.GA28327@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 23, 2012 at 12:23:10PM +0200, Gregory CLEMENT wrote: > On 10/23/2012 12:00 PM, Russell King - ARM Linux wrote: > > On Tue, Oct 23, 2012 at 11:43:02AM +0200, Gregory CLEMENT wrote: > >> On 10/23/2012 11:01 AM, Russell King - ARM Linux wrote: > >>> On Thu, Sep 27, 2012 at 11:35:23AM +0200, Gregory CLEMENT wrote: > >>>> Aurora Cache Controller was designed to be compatible with the ARM L2 > >>>> Cache Controller. It comes with some difference or improvement such > >>>> as: > >>>> - no cache id part number available through hardware (need to get it > >>>> by the DT). > >>>> - always write through mode available. > >>>> - two flavors of the controller outer cache and system cache (meaning > >>>> maintenance operations on L1 are broadcasted to the L2 and L2 > >>>> performs the same operation). > >>>> - in outer cache mode, the cache maintenance operations are improved and > >>>> can be done on a range inside a page and are not limited to a cache > >>>> line. > >>> > >>> This adds new build warnings: > >>> > >>> arch/arm/mm/cache-l2x0.c:328:13: warning: 'aurora_inv_range' defined but not used > >>> arch/arm/mm/cache-l2x0.c:347:13: warning: 'aurora_clean_range' defined but not used > >>> arch/arm/mm/cache-l2x0.c:365:13: warning: 'aurora_flush_range' defined but not used > >>> > >>> to the realview build (non-DT). Please investigate, thanks. > >> > >> OK I found the problem: aurora cache support is new so it is only > >> enable with device tree support. I moved all this functions in the > >> under OF_CONFIG (see the patch below). Do you want I submit it on the > >> patch system, or can you get it directly from this email? > > > > Easier by the patch system, and much less likely to get buried and lost > > between now and when I do the update, thanks. > > > OK, the initial patch 7547/1 was superseded by the patch 7547/2 that I have just > pushed in the patch system. I hope I have done it right. I know it's been a while, but it looks like it's still producing a warning. arch/arm/mm/cache-l2x0.c:37:12: warning: 'l2_wt_override' defined but not used This seems to be used only by the aurora code, which is wholely contained within a CONFIG_OF block, and this is outside of said block...