From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1 v2] usb: at91_udc: fix typo on vubs pullup valid check
Date: Mon, 5 Nov 2012 09:42:04 +0000 [thread overview]
Message-ID: <20121105094204.GD28327@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121105093451.GA20063@game.jcrosoft.org>
Subject: usb: at91_udc: fix typo on vubs pullup valid check
^^^^
typo.
On Mon, Nov 05, 2012 at 10:34:52AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> if the gpio is not valid complain
>
> since 3285e0ec088febc5a88f57ddd78385a7da71476c
> ARM: at91/udc: use gpio_is_valid to check the gpio
Poor description.
"The check for a valid vbus pullup gpio in commit 3285e0ec088f (ARM: at91/udc:
use gpio_is_valid to check the gpio) is inverted. Fix this."
would be much better because it describes what the the actual problem is.
Your description could mean that it's missing the error return path, or
maybe you're adding a log message to the failure case, or...
prev parent reply other threads:[~2012-11-05 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 9:34 [PATCH 1/1 v2] usb: at91_udc: fix typo on vubs pullup valid check Jean-Christophe PLAGNIOL-VILLARD
2012-11-05 9:42 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105094204.GD28327@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).