From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: PMU: fix runtime PM enable
Date: Mon, 5 Nov 2012 07:30:44 -0800 [thread overview]
Message-ID: <20121105153044.GE4953@atomide.com> (raw)
In-Reply-To: <20121026100312.GF20914@mudshark.cambridge.arm.com>
* Will Deacon <will.deacon@arm.com> [121026 03:04]:
> On Thu, Oct 25, 2012 at 09:23:18PM +0100, Jon Hunter wrote:
> > Commit 7be2958 (ARM: PMU: Add runtime PM Support) updated the ARM PMU code to
> > use runtime PM which was prototyped and validated on the OMAP devices. In this
> > commit, there is no call pm_runtime_enable() and for OMAP devices
> > pm_runtime_enable() is currently being called from the OMAP PMU code when the
> > PMU device is created. However, there are two problems with this:
> >
> > 1. For any other ARM device wishing to use runtime PM for PMU they will need
> > to call pm_runtime_enable() for runtime PM to work.
> > 2. When booting with device-tree and using device-tree to create the PMU
> > device, pm_runtime_enable() needs to be called from within the ARM PERF
> > driver as we are no longer calling any device specific code to create the
> > device. Hence, PMU does not work on OMAP devices that use the runtime PM
> > callbacks when using device-tree to create the PMU device.
> >
> > Therefore, call pm_runtime_enable() directly from the ARM PMU driver when
> > registering the device. For platforms that do not use runtime PM,
> > pm_runtime_enable() does nothing and for platforms that do use runtime PM but
> > may not require it specifically for PMU, this will just add a little overhead
> > when initialising and uninitialising the PMU device.
> >
> > Tested with PERF on OMAP2420, OMAP3430 and OMAP4460.
> >
> > V2 changes:
> > - Call pm_runtime_enable() unconditionally on registering the PMU device.
> >
> > Signed-off-by: Jon Hunter <jon-hunter@ti.com>
> > ---
>
> Cheers Jon! Looks a bit weird without the matching pm_runtime_disable, but
> we don't really have anywhere to put that since the PMU is not deregistered.
>
> Can we split this patch into two (even smaller!) patches so that I can take
> the perf part and the omap bit can go to Tony?
The omap bit looks OK for me to queue via perf:
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2012-11-05 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 20:23 [PATCH V2] ARM: PMU: fix runtime PM enable Jon Hunter
2012-10-25 21:38 ` Kevin Hilman
2012-10-26 10:03 ` Will Deacon
2012-11-05 15:30 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105153044.GE4953@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).