From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: setup_mm_for_reboot(): use flush_cache_louis()
Date: Tue, 6 Nov 2012 21:41:37 +0000 [thread overview]
Message-ID: <20121106214137.GA21764@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1211061610070.21033@xanadu.home>
On Tue, Nov 06, 2012 at 09:12:27PM +0000, Nicolas Pitre wrote:
>
> ... instead of flush_cache_all(). The later unconditionally flushes
> the L2 cache on ARMv7 architectures such as Cortex A15 and A7 which
> is costly and unnecessary in some scenarios where setup_mm_for_reboot()
> is used. If L2 has to be flushed as well, it should already be done
> separately on other architectures anyway.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
>
> diff --git a/arch/arm/mm/idmap.c b/arch/arm/mm/idmap.c
> index ab88ed4f8e..2c61085a10 100644
> --- a/arch/arm/mm/idmap.c
> +++ b/arch/arm/mm/idmap.c
> @@ -104,7 +104,7 @@ early_initcall(init_static_idmap);
> void setup_mm_for_reboot(void)
> {
> /* Clean and invalidate L1. */
> - flush_cache_all();
> + flush_cache_louis();
>
> /* Switch to the identity mapping. */
> cpu_switch_mm(idmap_pgd, &init_mm);
We could probably even predicate this on the half-implemented
TLB_CAN_READ_FROM_L1_CACHE option, but that can come later.
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2012-11-06 21:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 21:12 [PATCH] ARM: setup_mm_for_reboot(): use flush_cache_louis() Nicolas Pitre
2012-11-06 21:41 ` Will Deacon [this message]
2012-11-06 21:57 ` Santosh Shilimkar
2012-11-07 9:47 ` Lorenzo Pieralisi
2012-11-07 14:16 ` Santosh Shilimkar
2012-11-06 22:04 ` Russell King - ARM Linux
2012-11-06 22:53 ` Nicolas Pitre
2012-11-07 9:51 ` Russell King - ARM Linux
2012-11-07 9:51 ` Will Deacon
2012-11-07 9:56 ` Russell King - ARM Linux
2012-11-07 10:08 ` Will Deacon
2012-11-07 18:03 ` Nicolas Pitre
2012-11-07 18:41 ` Will Deacon
2012-11-07 20:10 ` Nicolas Pitre
2012-11-08 16:26 ` Will Deacon
2012-11-08 18:56 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106214137.GA21764@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).