From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: AT91SAM9G45: same platform data structure for all crypto peripherals
Date: Wed, 7 Nov 2012 16:50:26 +0100 [thread overview]
Message-ID: <20121107165026.4e64422f@eb-e6520> (raw)
In-Reply-To: <20121107152615.GD4576@game.jcrosoft.org>
Hi Jean-Christophe,
Le Wed, 7 Nov 2012 16:26:15 +0100,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a ?crit :
> > @@ -1931,9 +1931,9 @@ static struct platform_device at91sam9g45_aes_device = {
> > static void __init at91_add_device_aes(void)
> > {
> > struct at_dma_slave *atslave;
> > - struct aes_dma_data *alt_atslave;
> > + struct crypto_dma_data *alt_atslave;
> >
> > - alt_atslave = kzalloc(sizeof(struct aes_dma_data), GFP_KERNEL);
> > + alt_atslave = kzalloc(sizeof(struct crypto_dma_data), GFP_KERNEL);
> we do not check the result of kzalloc ouch
>
> and why we allocate it?
>
for both remarks : that's the way it's done in at91_add_device_mci since
75305d768d296a07fd02df9af3e5de326df1c72e
A v2 will follow (and also a fix for at91_add_device_mci).
Eric
next prev parent reply other threads:[~2012-11-07 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 16:32 [PATCH 2/5] ARM: AT91SAM9G45: same platform data structure for all crypto peripherals Nicolas Royer
2012-11-07 15:26 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-07 15:50 ` Eric Bénard [this message]
2012-11-07 16:27 ` [PATCH 2/5 v2] " Nicolas Royer
2012-11-07 16:45 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-07 16:59 ` Eric Bénard
2012-11-07 17:12 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-07 17:34 ` [PATCH 2/5 v3] " Nicolas Royer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121107165026.4e64422f@eb-e6520 \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).