linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] OF: Add helper for matching against linux, stdout-path
Date: Thu, 15 Nov 2012 09:04:53 +0100	[thread overview]
Message-ID: <20121115080453.GW10369@pengutronix.de> (raw)
In-Reply-To: <CACxGe6uW+XN6RDnP+8QFXaCYqqPZO4dZM_aynR6AVMYZT=KuMg@mail.gmail.com>

On Wed, Nov 14, 2012 at 08:49:54PM +0000, Grant Likely wrote:
> > +int of_device_is_stdout_path(struct device_node *dn)
> > +{
> > +       const char *name;
> > +
> > +       name = of_get_property(of_chosen, "linux,stdout-path", NULL);
> > +       if (name == NULL)
> > +               return 0;
> > +
> > +       if (dn == of_find_node_by_path(name))
> 
> need to of_node_put() the return value of of_find_node_by_path()
> 
> > +               return 1;
> > +
> > +       return 0;
> > +}
> 
> Hi Sascha,
> 
> I'm fine with the helper, but there really is no need for a completely
> separate .c file. Just put it in drivers/of/base.c.

Agreed.

Thanks,
 Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-11-15  8:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  9:48 [PATCH v3] linux,stdout-path helper Sascha Hauer
2012-11-02  9:48 ` [PATCH 1/3] OF: Add helper for matching against linux,stdout-path Sascha Hauer
2012-11-14 20:43   ` [PATCH 1/3] OF: Add helper for matching against linux, stdout-path Greg Kroah-Hartman
2012-11-14 20:49   ` Grant Likely
2012-11-15  8:04     ` Sascha Hauer [this message]
2012-11-15  8:49     ` Sascha Hauer
2012-11-15  9:10       ` Grant Likely
2012-11-02  9:48 ` [PATCH 2/3] serial: i.MX: Make console support non optional Sascha Hauer
2012-11-02  9:48 ` [PATCH 3/3] serial: i.MX: evaluate linux,stdout-path property Sascha Hauer
  -- strict thread matches above, loose matches on Subject: below --
2012-11-15  9:31 [PATCH v4] linux,stdout-path helper Sascha Hauer
2012-11-15  9:31 ` [PATCH 1/3] OF: Add helper for matching against linux,stdout-path Sascha Hauer
2012-11-19  9:52   ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-20 16:51     ` [PATCH 1/3] OF: Add helper for matching against linux, stdout-path Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121115080453.GW10369@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).