From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
Date: Thu, 15 Nov 2012 10:29:53 +0100 [thread overview]
Message-ID: <20121115092953.GA418@pengutronix.de> (raw)
In-Reply-To: <20121115084858.GA29668@bnru10>
> > - if (timeout < 0) {
> > - dev_err(&dev->adev->dev,
> > - "wait_for_completion_timeout "
> > - "returned %d waiting for event\n", timeout);
> > - status = timeout;
> > - }
> > -
> No, it is wrong. You need to update the status variable in the case of timeout.
Looking at the patch context, such code comes later.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121115/f7edc23a/attachment.sig>
next prev parent reply other threads:[~2012-11-15 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 17:18 [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Chuansheng Liu
2012-11-12 17:26 ` Wolfram Sang
2012-11-13 1:21 ` Liu, Chuansheng
2012-11-13 7:58 ` Wolfram Sang
2012-11-13 8:00 ` Liu, Chuansheng
[not found] ` <CACRpkdYekQF5111NSNSPeaHdxgS_gpXkCjqT1n-n1_iAdDXbSg@mail.gmail.com>
2012-11-15 8:49 ` Fwd: " Srinidhi Kasagar
2012-11-15 9:29 ` Wolfram Sang [this message]
2012-11-15 9:57 ` Srinidhi Kasagar
2012-11-15 10:18 ` Wolfram Sang
2012-11-15 11:18 ` Srinidhi Kasagar
2012-11-15 10:52 ` Chuansheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115092953.GA418@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).