From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Thu, 15 Nov 2012 14:56:35 +0100 Subject: [PATCH 1/4] pinctrl: dove: Prevent NULL dereference if of_match_device returns NULL In-Reply-To: References: <1352955096.6793.1.camel@phoenix> <20121115083511.08f5a16f@skate> Message-ID: <20121115145635.2fae2fc9@skate> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Axel Lin, On Thu, 15 Nov 2012 21:44:07 +0800, Axel Lin wrote: > BTW, I found there is no way to compile the dove and kirkwood pinctrl > drivers. > I need add below patch to compile these two drivers, how do you think about > below patch? > ( In dove, the USE_OF is optional, it is selected only when MACH_DOVE_DT is > enabled ) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 14f8160..dda6785 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -531,6 +531,8 @@ config ARCH_DOVE > select CPU_V7 > select GENERIC_CLOCKEVENTS > select MIGHT_HAVE_PCI > + select PINCTRL > + select PINCTRL_DOVE if USE_OF > select PLAT_ORION_LEGACY > select USB_ARCH_HAS_EHCI > help > @@ -542,6 +544,8 @@ config ARCH_KIRKWOOD > select CPU_FEROCEON > select GENERIC_CLOCKEVENTS > select PCI > + select PINCTRL > + select PINCTRL_KIRKWOOD > select PLAT_ORION_LEGACY > help > Support for the following Marvell Kirkwood series SoCs: See "[PATCH 1/5] ARM: Kirkwood: Allow use of pinctrl" and "[PATCH 4/5] ARM: Dove: Make use of pinctrl driver" which have been posted by Andrew Lunn on October, 24th. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com