From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] pinctrl: kirkwood: Prevent NULL dereference if of_match_device returns NULL
Date: Thu, 15 Nov 2012 20:18:33 +0100 [thread overview]
Message-ID: <20121115201833.07ec01c6@skate> (raw)
In-Reply-To: <1352955159.6793.2.camel@phoenix>
Dear Axel Lin,
On Thu, 15 Nov 2012 12:52:39 +0800, Axel Lin wrote:
> of_match_device() may return NULL.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Why? We already discussed together that this situation could not
happen: if you are in the probe() function, then there *must* be a
match, because the probe() function precisely gets called when there is
a match.
So unless you give more details about what the problem is, I don't
think this patch and the similar one you sent for Dove are useful.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-15 19:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 4:51 [PATCH 1/4] pinctrl: dove: Prevent NULL dereference if of_match_device returns NULL Axel Lin
2012-11-15 4:52 ` [PATCH 2/4] pinctrl: kirkwood: " Axel Lin
2012-11-15 19:18 ` Thomas Petazzoni [this message]
2012-11-15 4:54 ` [PATCH 3/4] pinctrl: at91: " Axel Lin
2012-11-15 4:58 ` [PATCH RESEND " Axel Lin
2012-11-15 8:23 ` Nicolas Ferre
2012-11-15 10:00 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-16 8:36 ` Nicolas Ferre
2012-11-16 9:39 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 4:56 ` [PATCH 4/4] pinctrl: nomadik: " Axel Lin
2012-11-15 14:42 ` Linus Walleij
2012-11-15 15:15 ` Lee Jones
2012-11-15 7:35 ` [PATCH 1/4] pinctrl: dove: " Thomas Petazzoni
2012-11-15 13:44 ` Axel Lin
2012-11-15 13:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115201833.07ec01c6@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).