linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: joro@8bytes.org ('Joerg Roedel')
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] iommu/exynos: enhancements of System MMU driver with DT
Date: Sat, 17 Nov 2012 13:49:18 +0100	[thread overview]
Message-ID: <20121117124918.GC11220@8bytes.org> (raw)
In-Reply-To: <002401cdc245$32dbf3e0$9893dba0$%cho@samsung.com>

On Wed, Nov 14, 2012 at 05:51:12PM +0900, Cho KyongHo wrote:
> This commit enhances power management of System MMU and its client
> devices with the following changes:
>  - Each System MMU device becomes the parent device of its client
>    device while probe(). Thus, exynos-iommu driver must be initialized
>    before client devices.
>  - System MMU driver does not pm_runtime_get/put() by itself and runtime
>    power gating is performed by client devices.
>  - System is safe when suspend/resume without any care by client device
>    drivers.
> 
> In addition, System MMUs can be seperate into several groups that are
> belongs to a single client device like FIMC-IS block. If such blocks are
> controlled by a single device descriptor, all System MMUs in the blocks
> must be enabled/disabled by a single device descriptor. The problem is
> that clock gating and power gating may be not the same among all System
> MMUs in the blocks. Thus, System MMUs are grouped by clock gating and
> power gating and they are chained by parent-child relationships.
> 
> exynos-iommu driver now also supports debugfs to identify the state of
> each System MMU.
> 
> The last big change is to support DT. The desription of the properties
> of DT nodes are described in the source file.
> 
> Signed-off-by: KyongHo Cho <pullip.cho@samsung.com>
> ---
>  drivers/iommu/Kconfig        |   17 +-
>  drivers/iommu/exynos-iommu.c | 1420 +++++++++++++++++++++++++++++++-----------
>  2 files changed, 1077 insertions(+), 360 deletions(-)

This patch does multiple things and is quite large. Please split it down
into reasonable chunks and resubmit.

Patches 1-3 look good to me and I do not mind taking them for 3.8.
Please let me know if you prefer these patches standalone in 3.8 or
together with this patch split up.


	Joerg

  reply	other threads:[~2012-11-17 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14  8:51 [PATCH 4/4] iommu/exynos: enhancements of System MMU driver with DT Cho KyongHo
2012-11-17 12:49 ` 'Joerg Roedel' [this message]
2012-11-19  8:12   ` KyongHo Cho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121117124918.GC11220@8bytes.org \
    --to=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).