From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] Add support for generic BCM SoC chipsets
Date: Sat, 17 Nov 2012 17:21:14 +0000 [thread overview]
Message-ID: <201211171721.15021.arnd@arndb.de> (raw)
In-Reply-To: <CAGFynZ-Ana17ngAvns=WgXErrqMcgD=JxrogqKZGAYpzsejE9w@mail.gmail.com>
On Saturday 17 November 2012, Christian Daudt wrote:
> >> diff --git a/Documentation/devicetree/bindings/arm/bcm/bcm281xx.txt b/Documentation/devicetree/bindings/arm/bcm/bcm281xx.txt
> >
> >> +Required root node property:
> >> +
> >> +compatible = "bcm,bcm281xx";
> >
> > Hmm. I still tend to think we should list the specific SoC rather than
> > the family here, but I guess if you're sure there won't be any SW
> > compatibility between the different SoCs in the series, this is fine.
> >
>
> right now I expect to be able to use the family thoughout, so I'll stick to it.
>
But that's not how the compatible property is supposed to work: Each compatible
value should refer to a specific property, and not include wildcards.
If you have one driver (or platform file in this case) that can deal with
a whole family of devices, the normal solution is to list the name of the oldest
part in the compatible string as the most generic part, and then list the
name of the new part as the specific one.
Arnd
next prev parent reply other threads:[~2012-11-17 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 21:51 [PATCH V3] Add support for generic BCM SoC chipsets Christian Daudt
2012-11-17 4:10 ` Stephen Warren
2012-11-17 16:07 ` Christian Daudt
2012-11-17 17:21 ` Arnd Bergmann [this message]
2012-11-17 17:53 ` Christian Daudt
2012-11-17 18:04 ` Arnd Bergmann
2012-11-17 23:39 ` Christian Daudt
2012-11-18 0:02 ` Christian Daudt
2012-11-18 11:32 ` Arnd Bergmann
2012-11-18 5:50 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211171721.15021.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).