From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Dove: Fix irq_to_pmu()
Date: Sun, 18 Nov 2012 16:39:32 +0000 [thread overview]
Message-ID: <20121118163932.GW3290@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121118162944.GV3290@n2100.arm.linux.org.uk>
PMU interrupts start at IRQ_DOVE_PMU_START, not IRQ_DOVE_PMU_START + 1.
Fix the condition. (It may have been less likely to occur had the code
been written "if (irq >= IRQ_DOVE_PMU_START" which imho is the easier
to understand notation, and matches the normal way of thinking about
these things.)
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
arch/arm/mach-dove/include/mach/pm.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-dove/include/mach/pm.h b/arch/arm/mach-dove/include/mach/pm.h
index 1c942c0..02a0073 100644
--- a/arch/arm/mach-dove/include/mach/pm.h
+++ b/arch/arm/mach-dove/include/mach/pm.h
@@ -184,7 +184,7 @@ static inline int pmu_to_irq(int pin)
static inline int irq_to_pmu(int irq)
{
- if (IRQ_DOVE_PMU_START < irq && irq < NR_IRQS)
+ if (IRQ_DOVE_PMU_START <= irq && irq < NR_IRQS)
return irq - IRQ_DOVE_PMU_START;
return -EINVAL;
next prev parent reply other threads:[~2012-11-18 16:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 16:29 [PATCH] Dove: Attempt to fix PMU/RTC interrupts Russell King - ARM Linux
2012-11-18 16:39 ` Russell King - ARM Linux [this message]
2012-11-18 19:00 ` [PATCH] Dove: Fix irq_to_pmu() Sergei Shtylyov
2012-11-18 20:38 ` Russell King - ARM Linux
2012-11-18 21:02 ` Jason Cooper
2012-11-18 22:31 ` Russell King - ARM Linux
2012-11-18 23:08 ` Russell King - ARM Linux
2012-11-18 23:12 ` Jason Cooper
2012-11-18 23:09 ` kirkwood i2s lockup, was: " Jason Cooper
2012-11-19 6:11 ` Andrew Lunn
2012-11-21 15:59 ` [PATCH] Dove: Attempt to fix PMU/RTC interrupts Andrew Lunn
2012-11-21 16:53 ` Russell King - ARM Linux
2012-11-21 16:57 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121118163932.GW3290@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).