From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] DMA: mv_xor: Add a device_control function
Date: Sun, 18 Nov 2012 18:40:23 +0100 [thread overview]
Message-ID: <20121118184023.5bcd8141@skate> (raw)
In-Reply-To: <1353235498-22638-1-git-send-email-andrew@lunn.ch>
Andrew,
On Sun, 18 Nov 2012 11:44:56 +0100, Andrew Lunn wrote:
> The dmatest module for DMA engines calls
>
> device_control(dtc->chan, DMA_TERMINATE_ALL, 0);
>
> after completing the tests. The documentation in
> include/linux/dmaengine.h suggests this function is optional and
> dma_async_device_register() also does not BUG_ON() when not passed a
> function. However, dmatest is not the only code in the kernel
> unconditionally calling device_control. So add an implementation
> indicating all operations are not implemented.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Thanks, I have applied your patch and made it part of the XOR patch set
I have, for which I intend to send a pull request to you tomorrow.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2012-11-18 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 10:44 [PATCH v2 1/2] DMA: mv_xor: Add a device_control function Andrew Lunn
2012-11-18 10:44 ` [PATCH v2 2/2] ARM: Kirkwood: Convert XOR instantiation to DT Andrew Lunn
2012-11-18 17:40 ` Thomas Petazzoni
2012-11-18 18:27 ` Andrew Lunn
2012-11-19 6:37 ` Jason Cooper
2012-11-19 6:41 ` Andrew Lunn
2012-11-19 6:54 ` Jason Cooper
2012-11-18 17:40 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121118184023.5bcd8141@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).