From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: arm: mvebu: Various mvebu clock fixes/improvements
Date: Tue, 20 Nov 2012 11:50:54 +0100 [thread overview]
Message-ID: <20121120115054.6425563a@skate> (raw)
In-Reply-To: <20121120110636.7306b00e@skate>
On Tue, 20 Nov 2012 11:06:36 +0100, Thomas Petazzoni wrote:
> Hum, I will check this. But I think that the point that lead me to look
> into the clocks is that when I added:
>
> clocks = <&gate_clk xx>;
>
> to my Ethernet DT nodes, then clk_get() was returning an error, until I
> enabled the gating clocks. But I'll double check that.
It is indeed not fatal with SATA because the driver tries to get the
clock, and if it can't, the driver just gives up.
However, with the mvneta driver, it really wants the clock (the driver
needs at some point to do a clk_get_rate(), so we have to have a
clock), and in this case, not having the gating clocks is an issue.
That said, since the mvneta driver is new, I don't mind if it is
non-functional up to the point where the gating clocks are enabled.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-20 10:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 16:52 arm: mvebu: Various mvebu clock fixes/improvements Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 1/7] clk: mvebu: init all mvebu clock types from mvebu_clocks_init() Thomas Petazzoni
2012-11-19 18:25 ` Andrew Lunn
2012-11-19 18:44 ` Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 2/7] clk: mvebu: move clk-cpu compatible strings into the clk-cpu driver Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 3/7] clk: mvebu: rename mvebu_clk_gating_init() to mvebu_gating_clk_init() Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 4/7] arm: mvebu: move DT cpu clock nodes to the Armada XP specific .dtsi Thomas Petazzoni
2012-11-19 18:38 ` Andrew Lunn
2012-11-19 18:50 ` Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 5/7] clk: mvebu: rename *-core-clocks to *-core-clock Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 6/7] clk: mvebu: rename armada-xp-cpu-clockctrl to armada-xp-cpu-clock Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 7/7] arm: mvebu: fix SATA clocks on Armada 370/XP Thomas Petazzoni
2012-11-19 18:27 ` arm: mvebu: Various mvebu clock fixes/improvements Andrew Lunn
2012-11-19 18:46 ` Thomas Petazzoni
2012-11-20 9:40 ` Thomas Petazzoni
2012-11-20 9:43 ` Andrew Lunn
2012-11-20 10:06 ` Thomas Petazzoni
2012-11-20 10:50 ` Thomas Petazzoni [this message]
2012-11-20 16:22 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120115054.6425563a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).