linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* OMAP* Latest build failures
@ 2012-11-14  9:26 Russell King - ARM Linux
  2012-11-14 10:08 ` Peter Ujfalusi
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2012-11-14  9:26 UTC (permalink / raw)
  To: linux-arm-kernel

OMAP* allnoconfig fails:

arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'

OMAP4 randconfig fails:

arch/arm/mach-omap2/cm_common.c: In function 'cm_register':
arch/arm/mach-omap2/cm_common.c:42:11: error: 'EINVAL' undeclared (first use in this function)
arch/arm/mach-omap2/cm_common.c:45:11: error: 'EEXIST' undeclared (first use in this function)
arch/arm/mach-omap2/cm_common.c: In function 'cm_unregister':
arch/arm/mach-omap2/cm_common.c:66:11: error: 'EINVAL' undeclared (first use in this function)

You know where to find the build information and results...

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14  9:26 OMAP* Latest build failures Russell King - ARM Linux
@ 2012-11-14 10:08 ` Peter Ujfalusi
  2012-11-14 10:35   ` Russell King - ARM Linux
  2012-11-14 11:45 ` Tomi Valkeinen
  2012-11-17  9:33 ` Russell King - ARM Linux
  2 siblings, 1 reply; 16+ messages in thread
From: Peter Ujfalusi @ 2012-11-14 10:08 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Russell,

On 11/14/2012 10:26 AM, Russell King - ARM Linux wrote:
> OMAP* allnoconfig fails:
> 
> arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'

Not sure what is going on here but neither of these are referenced within
twl-common.c directly.

> OMAP4 randconfig fails:
> 
> arch/arm/mach-omap2/cm_common.c: In function 'cm_register':
> arch/arm/mach-omap2/cm_common.c:42:11: error: 'EINVAL' undeclared (first use in this function)
> arch/arm/mach-omap2/cm_common.c:45:11: error: 'EEXIST' undeclared (first use in this function)
> arch/arm/mach-omap2/cm_common.c: In function 'cm_unregister':
> arch/arm/mach-omap2/cm_common.c:66:11: error: 'EINVAL' undeclared (first use in this function)

I have already sent a patch to fix this:
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/131341.html

> You know where to find the build information and results...

It seams I can not find the link in my mail archives. Could you point me to
the correct place?

-- 
P?ter

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14 10:08 ` Peter Ujfalusi
@ 2012-11-14 10:35   ` Russell King - ARM Linux
  0 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2012-11-14 10:35 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 14, 2012 at 11:08:35AM +0100, Peter Ujfalusi wrote:
> Hi Russell,
> 
> On 11/14/2012 10:26 AM, Russell King - ARM Linux wrote:
> > OMAP* allnoconfig fails:
> > 
> > arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> > twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> > arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> > twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> > arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> > twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> > twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> > twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> > arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> > twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> > twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
> 
> Not sure what is going on here but neither of these are referenced within
> twl-common.c directly.

You can't rely on the .c file issued by the linker.  omap_display_init()
is not in twl-common.c, but is in arch/arm/mach-omap2/display.c.  So
ignore the "twl-common.c".

> > OMAP4 randconfig fails:
> > 
> > arch/arm/mach-omap2/cm_common.c: In function 'cm_register':
> > arch/arm/mach-omap2/cm_common.c:42:11: error: 'EINVAL' undeclared (first use in this function)
> > arch/arm/mach-omap2/cm_common.c:45:11: error: 'EEXIST' undeclared (first use in this function)
> > arch/arm/mach-omap2/cm_common.c: In function 'cm_unregister':
> > arch/arm/mach-omap2/cm_common.c:66:11: error: 'EINVAL' undeclared (first use in this function)
> 
> I have already sent a patch to fix this:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/131341.html
> 
> > You know where to find the build information and results...
> 
> It seams I can not find the link in my mail archives. Could you point me to
> the correct place?

http://www.arm.linux.org.uk/developer/build/

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14  9:26 OMAP* Latest build failures Russell King - ARM Linux
  2012-11-14 10:08 ` Peter Ujfalusi
@ 2012-11-14 11:45 ` Tomi Valkeinen
  2012-11-14 16:48   ` Tony Lindgren
  2012-11-14 17:42   ` Russell King - ARM Linux
  2012-11-17  9:33 ` Russell King - ARM Linux
  2 siblings, 2 replies; 16+ messages in thread
From: Tomi Valkeinen @ 2012-11-14 11:45 UTC (permalink / raw)
  To: linux-arm-kernel

On 2012-11-14 11:26, Russell King - ARM Linux wrote:
> OMAP* allnoconfig fails:
> 
> arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'

I'm not able to reproduce this. I took v3.7-rc5, and the omap4430-sdp
noconfig
(http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2711),
and it builds fine for me.

>From the error log
(http://www.arm.linux.org.uk/developer/build/result.php?type=build&idx=2711)
I see that arch/arm/plat-omap/omap-pm-noop.c is not compiled, which is
where the above functions are. However, the config contains
CONFIG_OMAP_PM_NOOP=y, which should cause omap-pm-noop.c to be compiled.

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121114/caa91e54/attachment.sig>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14 11:45 ` Tomi Valkeinen
@ 2012-11-14 16:48   ` Tony Lindgren
  2012-11-14 16:59     ` Tony Lindgren
  2012-11-14 17:42   ` Russell King - ARM Linux
  1 sibling, 1 reply; 16+ messages in thread
From: Tony Lindgren @ 2012-11-14 16:48 UTC (permalink / raw)
  To: linux-arm-kernel

* Tomi Valkeinen <tomi.valkeinen@ti.com> [121114 03:47]:
> On 2012-11-14 11:26, Russell King - ARM Linux wrote:
> > OMAP* allnoconfig fails:
> > 
> > arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> > twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> > arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> > twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> > arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> > twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> > twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> > twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> > arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> > twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> > twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
> 
> I'm not able to reproduce this. I took v3.7-rc5, and the omap4430-sdp
> noconfig
> (http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2711),
> and it builds fine for me.

It happens if in arm-soc/for-next and rmk/for-next. Looks like the
CONFIG_OMAP_PM_NOOP can't be under CONFIG_PM in the makefile where I moved it
in commit 6e740f9a8.

Looks like in my test configs I run make oldnoconfig on Russell's seed
config, and I do get CONFIG_PM=y set while Russell's generated config
does not have that. No ideas yet why oldnoconfig add CONFIG_PM=y..

Anyways, patch below to make it behave like earlier.

Regards,

Tony

 
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 14 Nov 2012 08:40:00 -0800
Subject: [PATCH] ARM: OMAP: Fix compile for OMAP_PM_NOOP if PM is not selected

Commit 6e740f9a8 (ARM: OMAP: Move omap-pm-noop.c local to mach-omap2)
moved omap-pm-noop to be local to mach-omap2. However, the makefile
entry got placed within ifeq ($(CONFIG_PM),y) which was not the
case earlier.

Fix the issue by moving it out of the ifeq ($(CONFIG_PM),y) in
the makefile as these stubs are needed also when PM is not set.

Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>

--- a/arch/arm/mach-omap2/Makefile
+++ b/arch/arm/mach-omap2/Makefile
@@ -68,6 +68,8 @@ obj-$(CONFIG_ARCH_OMAP4)		+= opp4xxx_data.o
 endif
 
 # Power Management
+obj-$(CONFIG_OMAP_PM_NOOP)		+= omap-pm-noop.o
+
 ifeq ($(CONFIG_PM),y)
 obj-$(CONFIG_ARCH_OMAP2)		+= pm24xx.o
 obj-$(CONFIG_ARCH_OMAP2)		+= sleep24xx.o
@@ -75,7 +77,6 @@ obj-$(CONFIG_ARCH_OMAP3)		+= pm34xx.o sleep34xx.o
 obj-$(CONFIG_ARCH_OMAP4)		+= pm44xx.o omap-mpuss-lowpower.o
 obj-$(CONFIG_SOC_OMAP5)			+= omap-mpuss-lowpower.o
 obj-$(CONFIG_PM_DEBUG)			+= pm-debug.o
-obj-$(CONFIG_OMAP_PM_NOOP)		+= omap-pm-noop.o
 
 obj-$(CONFIG_POWER_AVS_OMAP)		+= sr_device.o
 obj-$(CONFIG_POWER_AVS_OMAP_CLASS3)    += smartreflex-class3.o

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14 16:48   ` Tony Lindgren
@ 2012-11-14 16:59     ` Tony Lindgren
  2012-11-14 17:17       ` Tony Lindgren
  0 siblings, 1 reply; 16+ messages in thread
From: Tony Lindgren @ 2012-11-14 16:59 UTC (permalink / raw)
  To: linux-arm-kernel

* Tony Lindgren <tony@atomide.com> [121114 08:50]:
> * Tomi Valkeinen <tomi.valkeinen@ti.com> [121114 03:47]:
> > On 2012-11-14 11:26, Russell King - ARM Linux wrote:
> > > OMAP* allnoconfig fails:
> > > 
> > > arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> > > twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> > > arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> > > twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> > > arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> > > twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> > > arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> > > twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> > > arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> > > twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> > > arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> > > twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> > > arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> > > twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
> > 
> > I'm not able to reproduce this. I took v3.7-rc5, and the omap4430-sdp
> > noconfig
> > (http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2711),
> > and it builds fine for me.
> 
> It happens if in arm-soc/for-next and rmk/for-next. Looks like the
> CONFIG_OMAP_PM_NOOP can't be under CONFIG_PM in the makefile where I moved it
> in commit 6e740f9a8.

This should say just "It happens in arm-soc/for-next".
 
> Looks like in my test configs I run make oldnoconfig on Russell's seed
> config, and I do get CONFIG_PM=y set while Russell's generated config
> does not have that. No ideas yet why oldnoconfig add CONFIG_PM=y..
> 
> Anyways, patch below to make it behave like earlier.
> 
> Regards,
> 
> Tony
> 
>  
> From: Tony Lindgren <tony@atomide.com>
> Date: Wed, 14 Nov 2012 08:40:00 -0800
> Subject: [PATCH] ARM: OMAP: Fix compile for OMAP_PM_NOOP if PM is not selected
> 
> Commit 6e740f9a8 (ARM: OMAP: Move omap-pm-noop.c local to mach-omap2)
> moved omap-pm-noop to be local to mach-omap2. However, the makefile
> entry got placed within ifeq ($(CONFIG_PM),y) which was not the
> case earlier.
> 
> Fix the issue by moving it out of the ifeq ($(CONFIG_PM),y) in
> the makefile as these stubs are needed also when PM is not set.
> 
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -68,6 +68,8 @@ obj-$(CONFIG_ARCH_OMAP4)		+= opp4xxx_data.o
>  endif
>  
>  # Power Management
> +obj-$(CONFIG_OMAP_PM_NOOP)		+= omap-pm-noop.o
> +
>  ifeq ($(CONFIG_PM),y)
>  obj-$(CONFIG_ARCH_OMAP2)		+= pm24xx.o
>  obj-$(CONFIG_ARCH_OMAP2)		+= sleep24xx.o
> @@ -75,7 +77,6 @@ obj-$(CONFIG_ARCH_OMAP3)		+= pm34xx.o sleep34xx.o
>  obj-$(CONFIG_ARCH_OMAP4)		+= pm44xx.o omap-mpuss-lowpower.o
>  obj-$(CONFIG_SOC_OMAP5)			+= omap-mpuss-lowpower.o
>  obj-$(CONFIG_PM_DEBUG)			+= pm-debug.o
> -obj-$(CONFIG_OMAP_PM_NOOP)		+= omap-pm-noop.o
>  
>  obj-$(CONFIG_POWER_AVS_OMAP)		+= sr_device.o
>  obj-$(CONFIG_POWER_AVS_OMAP_CLASS3)    += smartreflex-class3.o
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14 16:59     ` Tony Lindgren
@ 2012-11-14 17:17       ` Tony Lindgren
  2012-11-14 17:44         ` Russell King - ARM Linux
  0 siblings, 1 reply; 16+ messages in thread
From: Tony Lindgren @ 2012-11-14 17:17 UTC (permalink / raw)
  To: linux-arm-kernel

* Tony Lindgren <tony@atomide.com> [121114 09:02]:
> * Tony Lindgren <tony@atomide.com> [121114 08:50]:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [121114 03:47]:
> > > On 2012-11-14 11:26, Russell King - ARM Linux wrote:
> > > > OMAP* allnoconfig fails:
> > > > 
> > > > arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> > > > twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> > > > arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> > > > twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> > > > arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> > > > twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> > > > arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> > > > twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> > > > arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> > > > twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> > > > arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> > > > twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> > > > arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> > > > twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
> > > 
> > > I'm not able to reproduce this. I took v3.7-rc5, and the omap4430-sdp
> > > noconfig
> > > (http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2711),
> > > and it builds fine for me.
> > 
> > It happens if in arm-soc/for-next and rmk/for-next. Looks like the
> > CONFIG_OMAP_PM_NOOP can't be under CONFIG_PM in the makefile where I moved it
> > in commit 6e740f9a8.
> 
> This should say just "It happens in arm-soc/for-next".
>  
> > Looks like in my test configs I run make oldnoconfig on Russell's seed
> > config, and I do get CONFIG_PM=y set while Russell's generated config
> > does not have that. No ideas yet why oldnoconfig add CONFIG_PM=y..

Looks like the way to do this not to use oldnoconfig but to do:

$ make KCONFIG_ALLCONFIG=../configs/rmk-omap4430-sdp-noconfig allnoconfig

It seems that oldnoconfig will pick the new options that have default y?

Regards,

Tony

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14 11:45 ` Tomi Valkeinen
  2012-11-14 16:48   ` Tony Lindgren
@ 2012-11-14 17:42   ` Russell King - ARM Linux
  1 sibling, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2012-11-14 17:42 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 14, 2012 at 01:45:15PM +0200, Tomi Valkeinen wrote:
> On 2012-11-14 11:26, Russell King - ARM Linux wrote:
> > OMAP* allnoconfig fails:
> > 
> > arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> > twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> > arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> > twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> > arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> > twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> > twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> > twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> > arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> > twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> > twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
> 
> I'm not able to reproduce this. I took v3.7-rc5, and the omap4430-sdp
> noconfig
> (http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2711),
> and it builds fine for me.

That's not the kernel it builds - it builds mainline + my kernel (which
is basically for-next + a few bits more) + arm-soc.

This error only just poped up, so I'm guessing there is a change in arm-soc
which has broken it.

> I see that arch/arm/plat-omap/omap-pm-noop.c is not compiled, which is
> where the above functions are. However, the config contains
> CONFIG_OMAP_PM_NOOP=y, which should cause omap-pm-noop.c to be compiled.

Suggest you retry with v3.7-rc5 + arm-soc.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14 17:17       ` Tony Lindgren
@ 2012-11-14 17:44         ` Russell King - ARM Linux
  0 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2012-11-14 17:44 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 14, 2012 at 09:17:31AM -0800, Tony Lindgren wrote:
> Looks like the way to do this not to use oldnoconfig but to do:
> 
> $ make KCONFIG_ALLCONFIG=../configs/rmk-omap4430-sdp-noconfig allnoconfig
> 
> It seems that oldnoconfig will pick the new options that have default y?

That is the correct way to tell Kconfig to use the seed configuration -
that forces the options in the ALLCONFIG file to the values in there in
the final configuration while setting the rest of the options as desired
by the all*config target.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-14  9:26 OMAP* Latest build failures Russell King - ARM Linux
  2012-11-14 10:08 ` Peter Ujfalusi
  2012-11-14 11:45 ` Tomi Valkeinen
@ 2012-11-17  9:33 ` Russell King - ARM Linux
  2012-11-20 17:57   ` Tony Lindgren
  2 siblings, 1 reply; 16+ messages in thread
From: Russell King - ARM Linux @ 2012-11-17  9:33 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 14, 2012 at 09:26:43AM +0000, Russell King - ARM Linux wrote:
> OMAP* allnoconfig fails:
> 
> arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'

These are now gone, but we have a new warning:

arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used

And the randconfig found:

drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_readl':
drivers/staging/omap-thermal/omap-bandgap.c:46:2: error: implicit declaration of function 'readl'
drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_writel':
drivers/staging/omap-thermal/omap-bandgap.c:51:2: error: implicit declaration of function 'writel'

Which, as its in staging, maybe its not important but it's another source
of unnecessary failure.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-17  9:33 ` Russell King - ARM Linux
@ 2012-11-20 17:57   ` Tony Lindgren
  2012-11-20 23:00     ` Jon Hunter
  2012-11-28 14:04     ` Eduardo Valentin
  0 siblings, 2 replies; 16+ messages in thread
From: Tony Lindgren @ 2012-11-20 17:57 UTC (permalink / raw)
  To: linux-arm-kernel

* Russell King - ARM Linux <linux@arm.linux.org.uk> [121117 01:35]:
> On Wed, Nov 14, 2012 at 09:26:43AM +0000, Russell King - ARM Linux wrote:
> > OMAP* allnoconfig fails:
> > 
> > arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> > twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> > arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> > twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> > arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> > twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> > twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> > twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> > arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> > twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> > arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> > twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
> 
> These are now gone, but we have a new warning:
> 
> arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used

Jon, care to fix this one?
 
> And the randconfig found:
> 
> drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_readl':
> drivers/staging/omap-thermal/omap-bandgap.c:46:2: error: implicit declaration of function 'readl'
> drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_writel':
> drivers/staging/omap-thermal/omap-bandgap.c:51:2: error: implicit declaration of function 'writel'
> 
> Which, as its in staging, maybe its not important but it's another source
> of unnecessary failure.

Radhesh & Eduardo, can you fix this?

Regards,

Tony

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-20 17:57   ` Tony Lindgren
@ 2012-11-20 23:00     ` Jon Hunter
  2012-11-28 15:18       ` Russell King - ARM Linux
  2012-11-28 14:04     ` Eduardo Valentin
  1 sibling, 1 reply; 16+ messages in thread
From: Jon Hunter @ 2012-11-20 23:00 UTC (permalink / raw)
  To: linux-arm-kernel


On 11/20/2012 11:57 AM, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [121117 01:35]:
>> On Wed, Nov 14, 2012 at 09:26:43AM +0000, Russell King - ARM Linux wrote:
>>> OMAP* allnoconfig fails:
>>>
>>> arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
>>> twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
>>> arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
>>> twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
>>> arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
>>> twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
>>> arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
>>> twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
>>> arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
>>> twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
>>> arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
>>> twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
>>> arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
>>> twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
>>
>> These are now gone, but we have a new warning:
>>
>> arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used
> 
> Jon, care to fix this one?

Fix already available here [1]. I actually included this in my latest
pull request with some other timer clean-ups [2]. Let me know if you are
ok with this being part of this pull request or if you want to handle
this separately.

Cheers
Jon

[1] http://marc.info/?l=linux-omap&m=135300866115036&w=2
[2] http://marc.info/?l=linux-omap&m=135308624321232&w=2

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-20 17:57   ` Tony Lindgren
  2012-11-20 23:00     ` Jon Hunter
@ 2012-11-28 14:04     ` Eduardo Valentin
  2012-11-28 15:16       ` Russell King - ARM Linux
  1 sibling, 1 reply; 16+ messages in thread
From: Eduardo Valentin @ 2012-11-28 14:04 UTC (permalink / raw)
  To: linux-arm-kernel

Tony, Russell,

On 20-11-2012 13:57, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [121117 01:35]:
>> On Wed, Nov 14, 2012 at 09:26:43AM +0000, Russell King - ARM Linux wrote:
>>> OMAP* allnoconfig fails:
>>>
>>> arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
>>> twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
>>> arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
>>> twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
>>> arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
>>> twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
>>> arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
>>> twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
>>> arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
>>> twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
>>> arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
>>> twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
>>> arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
>>> twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
>>
>> These are now gone, but we have a new warning:
>>
>> arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used
>
> Jon, care to fix this one?
>
>> And the randconfig found:
>>
>> drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_readl':
>> drivers/staging/omap-thermal/omap-bandgap.c:46:2: error: implicit declaration of function 'readl'
>> drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_writel':
>> drivers/staging/omap-thermal/omap-bandgap.c:51:2: error: implicit declaration of function 'writel'
>>
>> Which, as its in staging, maybe its not important but it's another source
>> of unnecessary failure.

Well, it is important, thanks for checking this code. I appreciate if 
you keep your report.

>
> Radhesh & Eduardo, can you fix this?
>

This has been already fixed:
https://patchwork.kernel.org/patch/1734621/

And is already queued by Greg (staging-next):
http://git.kernel.org/?p=linux/kernel/git/gregkh/staging.git;a=commit;h=2aeeb8acfc19f8a9f283081bbf77919b61b92042

> Regards,
>
> Tony
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-28 14:04     ` Eduardo Valentin
@ 2012-11-28 15:16       ` Russell King - ARM Linux
  0 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2012-11-28 15:16 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 28, 2012 at 10:04:33AM -0400, Eduardo Valentin wrote:
> Tony, Russell,
>
> On 20-11-2012 13:57, Tony Lindgren wrote:
>> * Russell King - ARM Linux <linux@arm.linux.org.uk> [121117 01:35]:
>>> On Wed, Nov 14, 2012 at 09:26:43AM +0000, Russell King - ARM Linux wrote:
>>> And the randconfig found:
>>>
>>> drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_readl':
>>> drivers/staging/omap-thermal/omap-bandgap.c:46:2: error: implicit declaration of function 'readl'
>>> drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_writel':
>>> drivers/staging/omap-thermal/omap-bandgap.c:51:2: error: implicit declaration of function 'writel'
>>>
>>> Which, as its in staging, maybe its not important but it's another source
>>> of unnecessary failure.
>
> Well, it is important, thanks for checking this code. I appreciate if  
> you keep your report.
>
>>
>> Radhesh & Eduardo, can you fix this?
>>
>
> This has been already fixed:
> https://patchwork.kernel.org/patch/1734621/
>
> And is already queued by Greg (staging-next):
> http://git.kernel.org/?p=linux/kernel/git/gregkh/staging.git;a=commit;h=2aeeb8acfc19f8a9f283081bbf77919b61b92042

Good.  Now, there's also this too:

drivers/staging/omap-thermal/omap-thermal-common.c: In function 'omap_thermal_expose_sensor':
drivers/staging/omap-thermal/omap-thermal-common.c:259:28: error: storage size of 'pdata' isn't known
drivers/staging/omap-thermal/omap-thermal-common.c:261:2: error: 'data' undeclared (first use in this function)
drivers/staging/omap-thermal/omap-thermal-common.c:264:3: error: implicit declaration of function 'omap_thermal_build_pdata'
drivers/staging/omap-thermal/omap-thermal-common.c: In function 'omap_thermal_build_cpufreq_clip':
drivers/staging/omap-thermal/omap-thermal-common.c:330:41: error: dereferencing pointer to incomplete type
drivers/staging/omap-thermal/omap-thermal-common.c:343:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:343:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:343:6: error: dereferencing pointer to incomplete type
drivers/staging/omap-thermal/omap-thermal-common.c:344:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:344:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:344:6: error: dereferencing pointer to incomplete type
drivers/staging/omap-thermal/omap-thermal-common.c:345:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:345:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:345:6: error: dereferencing pointer to incomplete type
drivers/staging/omap-thermal/omap-thermal-common.c:375:2: error: too many arguments to function 'cpufreq_cooling_register'

Is it also fixed in Gregkh's staging-next branch?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-20 23:00     ` Jon Hunter
@ 2012-11-28 15:18       ` Russell King - ARM Linux
  2012-11-28 21:43         ` Jon Hunter
  0 siblings, 1 reply; 16+ messages in thread
From: Russell King - ARM Linux @ 2012-11-28 15:18 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 20, 2012 at 05:00:19PM -0600, Jon Hunter wrote:
> 
> On 11/20/2012 11:57 AM, Tony Lindgren wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [121117 01:35]:
> >> On Wed, Nov 14, 2012 at 09:26:43AM +0000, Russell King - ARM Linux wrote:
> >>> OMAP* allnoconfig fails:
> >>>
> >>> arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
> >>> twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
> >>> arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
> >>> twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
> >>> arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
> >>> twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
> >>> arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
> >>> twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
> >>> arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
> >>> twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
> >>> arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> >>> twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
> >>> arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
> >>> twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
> >>
> >> These are now gone, but we have a new warning:
> >>
> >> arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used
> > 
> > Jon, care to fix this one?
> 
> Fix already available here [1]. I actually included this in my latest
> pull request with some other timer clean-ups [2]. Let me know if you are
> ok with this being part of this pull request or if you want to handle
> this separately.
> 
> Cheers
> Jon
> 
> [1] http://marc.info/?l=linux-omap&m=135300866115036&w=2
> [2] http://marc.info/?l=linux-omap&m=135308624321232&w=2

Well, it's now two weeks on, and the warning is still there... what's going
on?  Why aren't fixes propagating upstream?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* OMAP* Latest build failures
  2012-11-28 15:18       ` Russell King - ARM Linux
@ 2012-11-28 21:43         ` Jon Hunter
  0 siblings, 0 replies; 16+ messages in thread
From: Jon Hunter @ 2012-11-28 21:43 UTC (permalink / raw)
  To: linux-arm-kernel


On 11/28/2012 09:18 AM, Russell King - ARM Linux wrote:
> On Tue, Nov 20, 2012 at 05:00:19PM -0600, Jon Hunter wrote:
>>
>> On 11/20/2012 11:57 AM, Tony Lindgren wrote:
>>> * Russell King - ARM Linux <linux@arm.linux.org.uk> [121117 01:35]:
>>>> On Wed, Nov 14, 2012 at 09:26:43AM +0000, Russell King - ARM Linux wrote:
>>>>> OMAP* allnoconfig fails:
>>>>>
>>>>> arch/arm/mach-omap2/built-in.o: In function `omap_dss_set_min_bus_tput':
>>>>> twl-common.c:(.text+0x1e08): undefined reference to `omap_pm_set_min_bus_tput'
>>>>> arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_init_postsetup':
>>>>> twl-common.c:(.init.text+0x8f8): undefined reference to `omap_pm_if_early_init'
>>>>> arch/arm/mach-omap2/built-in.o: In function `omap_serial_init_port':
>>>>> twl-common.c:(.init.text+0x1284): undefined reference to `omap_pm_get_dev_context_loss_count'
>>>>> arch/arm/mach-omap2/built-in.o: In function `omap_timer_init':
>>>>> twl-common.c:(.init.text+0x1544): undefined reference to `omap_pm_get_dev_context_loss_count'
>>>>> arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_init':
>>>>> twl-common.c:(.init.text+0x1af0): undefined reference to `omap_pm_if_init'
>>>>> arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
>>>>> twl-common.c:(.init.text+0x2168): undefined reference to `omap_pm_get_dev_context_loss_count'
>>>>> arch/arm/mach-omap2/built-in.o: In function `omap_display_init':
>>>>> twl-common.c:(.init.text+0x25cc): undefined reference to `omap_pm_get_dev_context_loss_count'
>>>>
>>>> These are now gone, but we have a new warning:
>>>>
>>>> arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used
>>>
>>> Jon, care to fix this one?
>>
>> Fix already available here [1]. I actually included this in my latest
>> pull request with some other timer clean-ups [2]. Let me know if you are
>> ok with this being part of this pull request or if you want to handle
>> this separately.
>>
>> Cheers
>> Jon
>>
>> [1] http://marc.info/?l=linux-omap&m=135300866115036&w=2
>> [2] http://marc.info/?l=linux-omap&m=135308624321232&w=2
> 
> Well, it's now two weeks on, and the warning is still there... what's going
> on?  Why aren't fixes propagating upstream?

I saw a pull request from Tony on Monday night [1], however, does not
appear to have made its way to ARM SoC yet. So it's on it's way.

Cheers
Jon

[1] http://marc.info/?l=linux-omap&m=135397838631792&w=2

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2012-11-28 21:43 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-14  9:26 OMAP* Latest build failures Russell King - ARM Linux
2012-11-14 10:08 ` Peter Ujfalusi
2012-11-14 10:35   ` Russell King - ARM Linux
2012-11-14 11:45 ` Tomi Valkeinen
2012-11-14 16:48   ` Tony Lindgren
2012-11-14 16:59     ` Tony Lindgren
2012-11-14 17:17       ` Tony Lindgren
2012-11-14 17:44         ` Russell King - ARM Linux
2012-11-14 17:42   ` Russell King - ARM Linux
2012-11-17  9:33 ` Russell King - ARM Linux
2012-11-20 17:57   ` Tony Lindgren
2012-11-20 23:00     ` Jon Hunter
2012-11-28 15:18       ` Russell King - ARM Linux
2012-11-28 21:43         ` Jon Hunter
2012-11-28 14:04     ` Eduardo Valentin
2012-11-28 15:16       ` Russell King - ARM Linux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).