From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/8] crypto: omap-sham: Add code to use dmaengine API
Date: Tue, 20 Nov 2012 17:10:28 -0800 [thread overview]
Message-ID: <20121121011027.GT18567@atomide.com> (raw)
In-Reply-To: <1353351301-6453-8-git-send-email-mgreer@animalcreek.com>
* Mark A. Greer <mgreer@animalcreek.com> [121119 10:58]:
> @@ -27,6 +29,10 @@
> #include <linux/platform_device.h>
> #include <linux/scatterlist.h>
> #include <linux/dma-mapping.h>
> +#ifndef OMAP_SHAM_DMA_PRIVATE
> +#include <linux/dmaengine.h>
> +#include <linux/omap-dma.h>
> +#endif
> #include <linux/pm_runtime.h>
> #include <linux/delay.h>
> #include <linux/crypto.h>
I think you should be able to drop the OMAP_SHAM_DMA_PRIVATE
from the include after I'll post one more patch to move the
omap private DMA header to linux/dma-mapping.h that we already
have until the dmaengine conversion is completed.
> @@ -37,8 +43,10 @@
> #include <crypto/hash.h>
> #include <crypto/internal/hash.h>
>
> +#ifdef OMAP_SHAM_DMA_PRIVATE
> #include <plat/dma.h>
And then this can be dropped.
> #include <mach/irqs.h>
But this needs to go too, as we have that only for omap1 when
ARM multiplatform is enabled for omap2+. The interrupt should
be passed in platform_data.
However, if there are some indirect dependencies for omap1,
you can just put it into ifdef CONFIG_ARCH_OMAP1 for now.
There's probably the same issue for the other series you
posted.
Regards,
Tony
next prev parent reply other threads:[~2012-11-21 1:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 18:54 [PATCH v4 0/8] crypto: omap-sham updates Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 1/8] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 2/8] ARM: OMAP2xxx: hwmod: Add DMA support for SHAM module Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 3/8] ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 4/8] ARM: OMAP2+: Remove unnecessary message when no SHA IP is present Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 5/8] crypto: omap-sham: Remove cpu_is/omap_type check from driver Mark A. Greer
2012-11-21 1:02 ` Tony Lindgren
2012-11-19 18:54 ` [PATCH v4 6/8] crypto: omap-sham: Convert to use pm_runtime API Mark A. Greer
2012-11-19 18:55 ` [PATCH v4 7/8] crypto: omap-sham: Add code to use dmaengine API Mark A. Greer
2012-11-21 1:10 ` Tony Lindgren [this message]
2012-11-19 18:55 ` [PATCH v4 8/8] crypto: omap_sham: Remove usage of private DMA API Mark A. Greer
2012-12-05 10:28 ` [PATCH v4 0/8] crypto: omap-sham updates Kasatkin, Dmitry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121011027.GT18567@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).