From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: IRQ code inconsistencies across platforms
Date: Wed, 21 Nov 2012 14:53:30 +0000 [thread overview]
Message-ID: <20121121145330.3CCF53E0A47@localhost> (raw)
In-Reply-To: <53814.210.54.1.170.1349825180.squirrel@server.prisktech.co.nz>
On Wed, 10 Oct 2012 12:26:20 +1300 (NZDT), linux at prisktech.co.nz wrote:
> In arch/arm/common.gic.c:
>
> static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,
> urq_hw_number_t hw)
> {
> ...
> irq_set_chip_and_handler(irq, &gic_chip, handle_fasteoi_irq);
> set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
> }
>
> but in arch/arm/mach-pxa/irq.c:
>
> static int pxa_irq_map(struct irq_domain *d, unsigned int virq, urq_hw_number_t hw)
> {
> ...
> irq_set_chip_and_handler(hw, &pxa_internal_irq_chip, handle_level_irq);
> set_irq_flags(hw, IRQF_VALID);
> }
>
> Is it correct to use irq/virq or hw for irq_set_chip_and_handler/set_irq_flags?
>
> Both platforms are adding legacy domains, so while they both presumably work,
> one is slightly incorrect.
It should be irq. The mach-pxa code looks incorrect.
g.
prev parent reply other threads:[~2012-11-21 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 23:26 IRQ code inconsistencies across platforms linux at prisktech.co.nz
2012-11-21 14:53 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121145330.3CCF53E0A47@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).