From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Wed, 21 Nov 2012 16:05:55 +0100 Subject: [PATCH] ARM: Kirkwood: Update PCI-E fixup In-Reply-To: <20121121071906.GF19837@obsidianresearch.com> References: <20121121071906.GF19837@obsidianresearch.com> Message-ID: <20121121160555.0710e048@skate> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Jason Gunthorpe, On Wed, 21 Nov 2012 00:19:06 -0700, Jason Gunthorpe wrote: > +/* The root complex has a hardwired class of PCI_CLASS_MEMORY_OTHER, when it > + is operating as a root complex this needs to be switched to > + PCI_CLASS_BRIDGE_HOST or Linux will errantly try to process the BAR's on > + the device. Decoding setup is handled by the orion code. */ Sorry for this unique silly review comment, but this comment does not comply with the kernel CodingStyle for multicomments. It should be: /* * Blabla. * Blibli. */ Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com