From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: perf: fix link error when CONFIG_HW_PERF_EVENTS is not selected
Date: Thu, 22 Nov 2012 11:58:12 +0000 [thread overview]
Message-ID: <20121122115812.GD3113@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1353584851-17842-1-git-send-email-marc.zyngier@arm.com>
On Thu, Nov 22, 2012 at 11:47:31AM +0000, Marc Zyngier wrote:
> Commit e50c541 (ARM: perf: add guest vs host discrimination) broken the
> link as perf_instruction_pointer and perf_misc_flags are not defined
> when CONFIG_HW_PERF_EVENTS is not selected.
>
> As it make little sense to try and profile a guest without any HW event,
> just fallback to the original code when this config option is not selected.
>
> Reported-by: Russell King <linux@arm.linux.org.uk>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/include/asm/perf_event.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/include/asm/perf_event.h b/arch/arm/include/asm/perf_event.h
> index 00416ed..7558775 100644
> --- a/arch/arm/include/asm/perf_event.h
> +++ b/arch/arm/include/asm/perf_event.h
> @@ -21,9 +21,11 @@
> #define C(_x) PERF_COUNT_HW_CACHE_##_x
> #define CACHE_OP_UNSUPPORTED 0xFFFF
>
> +#ifdef CONFIG_HW_PERF_EVENTS
> struct pt_regs;
> extern unsigned long perf_instruction_pointer(struct pt_regs *regs);
> extern unsigned long perf_misc_flags(struct pt_regs *regs);
> #define perf_misc_flags(regs) perf_misc_flags(regs)
> +#endif
>
> #endif /* __ARM_PERF_EVENT_H__ */
> --
Acked-by: Will Deacon <will.deacon@arm.com>
Thanks Marc for the fix and Russell for reporting the issue.
Please can you stick this in the patch system as I don't have any other
perf patches pending for 3.8?
Will
next prev parent reply other threads:[~2012-11-22 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 11:47 [PATCH] ARM: perf: fix link error when CONFIG_HW_PERF_EVENTS is not selected Marc Zyngier
2012-11-22 11:58 ` Will Deacon [this message]
2012-11-22 12:08 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122115812.GD3113@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox