From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] imx27-dt: configure i2c1 gpio on armadeus apf27
Date: Mon, 26 Nov 2012 10:28:58 +0100 [thread overview]
Message-ID: <20121126102858.4ba818b0@skate> (raw)
In-Reply-To: <1353874625-14754-4-git-send-email-tremyfr@yahoo.fr>
Dear Philippe Reynes,
On Sun, 25 Nov 2012 21:17:04 +0100, Philippe Reynes wrote:
> static const struct of_dev_auxdata imx27_auxdata_lookup[] __initconst = {
> @@ -48,6 +49,10 @@ int apf27_lan8700_wakeup(struct phy_device *phydev)
> static void __init apf27_init(void)
> {
> phy_register_fixup_for_id("imx27-fec.0-1:1f", apf27_lan8700_wakeup);
> +
> + /* configure i2c1 gpio */
> + mxc_gpio_mode((GPIO_PORTD | GPIO_OUT | GPIO_PF | 17));
> + mxc_gpio_mode((GPIO_PORTD | GPIO_OUT | GPIO_PF | 18));
> }
I haven't followed i.MX 27 support lately, but this surely should be
done using a pinctrl driver. I see that there is a general pinctrl
driver for i.MX, but a drivers/pinctrl/pinctrl-imx27.c might be
missing. It would probably be a better idea to implement the missing
pinctrl driver, if not already available?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-26 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 20:17 [PATCH 0/4] apf27: enable Ethernet PHY and add support of ds1374 rtc Philippe Reynes
2012-11-25 20:17 ` [PATCH 1/4] apf27: enable Ethernet PHY Philippe Reynes
2012-11-25 20:17 ` [PATCH 2/4] ds1374: add support of device tree Philippe Reynes
2012-11-26 9:08 ` Thomas Petazzoni
2012-11-25 20:17 ` [PATCH 3/4] imx27-dt: configure i2c1 gpio on armadeus apf27 Philippe Reynes
2012-11-26 9:28 ` Thomas Petazzoni [this message]
2012-11-26 9:59 ` Sascha Hauer
2012-11-25 20:17 ` [PATCH 4/4] apf27: add rtc ds1374 to the device tree Philippe Reynes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126102858.4ba818b0@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).