* [PATCH] gpio: pl061: remove old comment
@ 2012-11-22 9:46 Baruch Siach
2012-11-26 6:53 ` Linus Walleij
2012-11-30 11:13 ` Grant Likely
0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2012-11-22 9:46 UTC (permalink / raw)
To: linux-arm-kernel
Since 3ab524754 (gpio: pl061: convert to use generic irq chip) we only have one
spinlock in struct pl061_gpio.
Cc: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
drivers/gpio/gpio-pl061.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
index b4b5da4..2b2e73c 100644
--- a/drivers/gpio/gpio-pl061.c
+++ b/drivers/gpio/gpio-pl061.c
@@ -48,12 +48,7 @@ struct pl061_context_save_regs {
#endif
struct pl061_gpio {
- /* Each of the two spinlocks protects a different set of hardware
- * regiters and data structurs. This decouples the code of the IRQ from
- * the GPIO code. This also makes the case of a GPIO routine call from
- * the IRQ code simpler.
- */
- spinlock_t lock; /* GPIO registers */
+ spinlock_t lock;
void __iomem *base;
int irq_base;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] gpio: pl061: remove old comment
2012-11-22 9:46 [PATCH] gpio: pl061: remove old comment Baruch Siach
@ 2012-11-26 6:53 ` Linus Walleij
2012-11-30 11:13 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2012-11-26 6:53 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 22, 2012 at 10:46 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Since 3ab524754 (gpio: pl061: convert to use generic irq chip) we only have one
> spinlock in struct pl061_gpio.
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] gpio: pl061: remove old comment
2012-11-22 9:46 [PATCH] gpio: pl061: remove old comment Baruch Siach
2012-11-26 6:53 ` Linus Walleij
@ 2012-11-30 11:13 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-11-30 11:13 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 22 Nov 2012 11:46:14 +0200, Baruch Siach <baruch@tkos.co.il> wrote:
> Since 3ab524754 (gpio: pl061: convert to use generic irq chip) we only have one
> spinlock in struct pl061_gpio.
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-pl061.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
> index b4b5da4..2b2e73c 100644
> --- a/drivers/gpio/gpio-pl061.c
> +++ b/drivers/gpio/gpio-pl061.c
> @@ -48,12 +48,7 @@ struct pl061_context_save_regs {
> #endif
>
> struct pl061_gpio {
> - /* Each of the two spinlocks protects a different set of hardware
> - * regiters and data structurs. This decouples the code of the IRQ from
> - * the GPIO code. This also makes the case of a GPIO routine call from
> - * the IRQ code simpler.
> - */
> - spinlock_t lock; /* GPIO registers */
> + spinlock_t lock;
>
> void __iomem *base;
> int irq_base;
> --
> 1.7.10.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-30 11:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-22 9:46 [PATCH] gpio: pl061: remove old comment Baruch Siach
2012-11-26 6:53 ` Linus Walleij
2012-11-30 11:13 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).