linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Add .smp entry for REALVIEW_EB
Date: Wed, 5 Dec 2012 18:18:36 +0000	[thread overview]
Message-ID: <20121205181836.GC18403@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1354634293-18343-1-git-send-email-steve.capper@arm.com>

Hi Steve,

On Tue, Dec 04, 2012 at 03:18:13PM +0000, Steve Capper wrote:
> The REALVIEW EB board can host tiles with multiple cores thus needs to be able
> to initialise SMP. There is, however, no .smp entry in the MACHINE_START
> struct for REALVIEW_EB.
> 
> This patch adds the appropriate .smp entry to this struct.
> 
> Signed-off-by: Steve Capper <steve.capper@arm.com>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  arch/arm/mach-realview/realview_eb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-realview/realview_eb.c b/arch/arm/mach-realview/realview_eb.c
> index d3b3cd2..28511d4 100644
> --- a/arch/arm/mach-realview/realview_eb.c
> +++ b/arch/arm/mach-realview/realview_eb.c
> @@ -467,6 +467,7 @@ static void __init realview_eb_init(void)
>  MACHINE_START(REALVIEW_EB, "ARM-RealView EB")
>  	/* Maintainer: ARM Ltd/Deep Blue Solutions Ltd */
>  	.atag_offset	= 0x100,
> +	.smp		= smp_ops(realview_smp_ops),
>  	.fixup		= realview_fixup,
>  	.map_io		= realview_eb_map_io,
>  	.init_early	= realview_init_early,

Please can you put this in the patch system? Mainline is broken on SMP EB
without it.

Will

  reply	other threads:[~2012-12-05 18:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 15:18 [PATCH] ARM: Add .smp entry for REALVIEW_EB Steve Capper
2012-12-05 18:18 ` Will Deacon [this message]
2012-12-06 10:49   ` Steve Capper
2012-12-06 10:54     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121205181836.GC18403@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).