linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver
Date: Thu, 06 Dec 2012 10:16:45 +0000	[thread overview]
Message-ID: <20121206101645.4C28E3E05A4@localhost> (raw)
In-Reply-To: <1352357665-7435-2-git-send-email-gautam.vivek@samsung.com>

On Thu, 08 Nov 2012 12:24:24 +0530, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Adding EHCI device tree node for Exynos5250 along with
> the device base adress and gpio line for vbus.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  .../devicetree/bindings/usb/exynos-usb.txt         |   25 ++++++++++++++++++++
>  arch/arm/boot/dts/exynos5250-smdk5250.dts          |    4 +++
>  arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++
>  arch/arm/mach-exynos/include/mach/map.h            |    1 +
>  arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 +
>  5 files changed, 38 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> new file mode 100644
> index 0000000..833f5cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> @@ -0,0 +1,25 @@
> +Samsung Exynos SoC USB controller
> +
> +The USB devices interface with USB controllers on Exynos SOCs.
> +The device node has following properties.
> +
> +EHCI
> +Required properties:
> + - compatible: should be "samsung,exynos-ehci" for USB 2.0

Ditto here. Please be specific in compatible strings.  "samsung,exynos5250-ehci"

Otherwise the binding looks fine to me.

g.

  parent reply	other threads:[~2012-12-06 10:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08  6:54 [PATCH v2 0/2] Enable ehci and ohci devices for exynos5250 Vivek Gautam
2012-11-08  6:54 ` [PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver Vivek Gautam
2012-11-08  8:07   ` Vivek Gautam
2012-11-08  8:19     ` Vivek Gautam
2012-12-03 13:31       ` Vivek Gautam
2012-12-06 10:16   ` Grant Likely [this message]
2012-12-06 10:38     ` Vivek Gautam
2012-11-08  6:54 ` [PATCH v2 2/2] ARM: Exynos5250: Enabling ohci-exynos driver Vivek Gautam
2012-11-08  8:07   ` Vivek Gautam
2012-11-08  8:21     ` Vivek Gautam
2012-12-03 13:34       ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121206101645.4C28E3E05A4@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).