From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: gpmi: reset BCH earlier, too, to avoid NAND startup problems
Date: Thu, 6 Dec 2012 17:58:00 +0100 [thread overview]
Message-ID: <20121206165800.GA17129@pengutronix.de> (raw)
In-Reply-To: <CAMiH66EPDKhd=pBJWhtm3P+qgGcdVbHD-hb93ZB7Ou7Sc=vByg@mail.gmail.com>
> > Did you power-cycle between each test or reboot? I still need to test if
> What's the meaning of "power-cycle"?
power off - power on
> I only tested with the soft reset, the power is never shut down.
OK.
> With your patch, we have resetted the BCH twice in the driver. Could
> we only reset BCH one time?
You tell me, please :) Is it needed when changing the layout? I don't
have any setup to test that. Unless I can test that, I prefer to not
remove it. I am a bit anxious, because the reason for the stalled BCH is
not fully understood and all I can reliably say is that resetting twice
does not hurt.
> Do you ever remove another reset-bch code, and test it?
It will probably work, but we don't cover the case of changing the
layout?
> Frankly speaking, it's strange to reset the BCH twice, and it makes no sense. :(
The stalled BCH makes no sense either, currently.
> I am afraid that we have to add three-reset-bch in the future, if we
> can not find the root cause.
Well, ask the IC guys if something can go wrong when the BCH has been
active and the GPMI gets reset and issues NAND commands (without needing
ECC).
> If you can remove another reset-bch code, i will ack the patch.
Removing code that late in the cycle without proof sounds dangerous to
me.
> > The setup needs to be done properly to ensure a consistent state at the
> > beginning, especially when somebody used the NAND before (ROM code,
> At the beginning? it's really interesting.
> I want to test it myself.
>
> could you wait for some time?
What is some time? :)
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121206/7fba6926/attachment.sig>
next prev parent reply other threads:[~2012-12-06 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 20:46 [PATCH] mtd: nand: gpmi: reset BCH earlier, too, to avoid NAND startup problems Wolfram Sang
2012-12-06 2:16 ` Huang Shijie
2012-12-06 9:52 ` Wolfram Sang
2012-12-06 14:58 ` Huang Shijie
2012-12-06 16:58 ` Wolfram Sang [this message]
2012-12-11 2:01 ` Huang Shijie
2012-12-12 15:11 ` Artem Bityutskiy
2012-12-12 16:01 ` Wolfram Sang
2012-12-13 11:41 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206165800.GA17129@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).