From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] I2C: EXYNOS: Add slave support to i2c
Date: Fri, 7 Dec 2012 12:33:43 +0000 [thread overview]
Message-ID: <20121207123343.GU14363@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <50C1DB05.7090500@linaro.org>
On Fri, Dec 07, 2012 at 05:33:17PM +0530, Tushar Behera wrote:
> On 12/03/2012 05:46 PM, Giridhar Maruthy wrote:
> > This patch adds slave support to i2c. The dt entry i2c-mode
> > decides at probe time if the controller needs to work in
> > slave mode and the controller is accordingly programmed.
(I don't have the original patches.)
Hmm. How has slave-mode support been tested?
Remembering that I2C slave devices do not initiate bus accesses, all
accesses will be started by some other master. How are you dealing
with the bytes received from the master, and how are you returning a
response to the master in reply to a read request?
We had support for this on PXA I2C through a callback from the driver
into PXA code (used for the Psion Teklogix Netbook device) and it worked
really well, but what you can't do is use the standard I2C interfaces
for slave mode.
next prev parent reply other threads:[~2012-12-07 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1354354961-28833-1-git-send-email-giridhar.maruthy@linaro.org>
2012-12-03 12:16 ` [PATCH] I2C: EXYNOS: Add slave support to i2c Giridhar Maruthy
2012-12-03 13:28 ` Kyungmin Park
2012-12-03 22:46 ` Giridhar Maruthy
2012-12-03 22:53 ` Giridhar Maruthy
2012-12-06 14:05 ` Subash Patel
2012-12-07 11:36 ` Giridhar Maruthy
2012-12-07 12:03 ` Tushar Behera
2012-12-07 12:33 ` Russell King - ARM Linux [this message]
2012-12-10 9:32 ` Giridhar Maruthy
2012-12-10 12:44 ` Russell King - ARM Linux
2012-12-10 8:10 ` Giridhar Maruthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207123343.GU14363@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).